From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SKU8Ot+86WHYaQAAgWs5BA (envelope-from ) for ; Thu, 20 Jan 2022 20:49:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WKQrN9+86WEfAAEAauVa8A (envelope-from ) for ; Thu, 20 Jan 2022 20:49:51 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B502E4636D for ; Thu, 20 Jan 2022 20:49:51 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 09F4A5F704; Thu, 20 Jan 2022 19:49:47 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id A0FE25F6D1 for ; Thu, 20 Jan 2022 19:49:43 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id CE4995FC01; Thu, 20 Jan 2022 14:49:42 -0500 (EST) Received: (nullmailer pid 363919 invoked by uid 1000); Thu, 20 Jan 2022 19:49:41 -0000 From: David Bremner To: Tomi Ollila , Gregor Zattler , Notmuch Mail Subject: Re: [PATCH 1/3] test/emacs: add known broken test for hidden tags In-Reply-To: <20220105010606.2034601-1-david@tethera.net> References: <20220105010606.2034601-1-david@tethera.net> Date: Thu, 20 Jan 2022 15:49:41 -0400 Message-ID: <874k5ygpbe.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: HNOSLR2LXEJHHDFL277I4MEGRSV43Z7A X-Message-ID-Hash: HNOSLR2LXEJHHDFL277I4MEGRSV43Z7A X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642708191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=trY8UOGyLEkQhltuceKOR71UUF9lcd9B78hMhUsPu44=; b=nDYiI2qHjTK6IpBILq5nVVbytiwIa2P4hQyinMU2QJtBXmoAk7Smx+PunGGwCyBTgzn2+Q gygf3JMncdQuUl5M6Gs1roCSc2q/fBE7VEzQ9Su8Pel+zHVg9r658zCTUPVq7e44SVxjRV +IiYpIDoovwi9pZCFe/mvYNNIlq8dUsKQXO+/UnKO0AWWloA2gd585ERlR0QpfzdrpcBQC yMK7u2Iqj56VZ99Ol8UDXXHPpJvccwLvWphWJtrSstTXAmSvnMdIAODZsRDe7ddlINYY95 Q4p7aS/Q5DPDJmk5UE39bSb2IGa9w47RIfkiawtv78CMzrf9HVV5y8br1SP/ww== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642708191; a=rsa-sha256; cv=none; b=eR8rnz5bqKEKsT2WK6c3YwFMZMgVdNDD3o+ivBB7bi6EyouoaNZzA2olpAnonnCqOYnh/3 QPVhHmBott7vDZVowVObI9AF3byvKbAU6XJCCigXgFm3L22SqexrtQegzPsUuOZTxvOMAz j3/I16nbukvB5HdkSGNGQaqyHZyrElae9XqXW8jmYREyD1ZAIohYYHJJzKtmIvCdvGZUh0 F/77mpYQlozBL4OraLkFwP550WNt861edxmFbg7jAWUzJmgAq9H3TDzZnAkXrtj+A9+iO2 BDXNvjouSJ0MgL9VPke3UffT6yB9I9ffVvRasUJ5xXD1NHPiPaUtq5N52rJoXg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: B502E4636D X-Spam-Score: -2.85 X-Migadu-Scanner: scn0.migadu.com X-TUID: wL3oMW+y3Gaf David Bremner writes: > Gregor Zattler observed that tags could be unintentionally hidden in > the "All tags" view, and Tomi Ollia worked out [2] that the issue was tags > that only occured on excluded messages. This test reproduces that bug. > > [1]: id:87wox1vovj.fsf@len.workgroup > [2]: id:m28t9faaim.fsf@guru.guru-group.fi Applied the series to master, with two trivial changes: one to indentation, one to capitalization. Interdiff follows. diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index cd7ac39c..9ac52c11 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -570,7 +570,7 @@ options will be handled as specified for (plist-get options :filter)))) "\n"))) (unless (= (notmuch--call-process-region (point-min) (point-max) notmuch-command - t t nil "count" "--exclude=false" "--batch") 0) + t t nil "count" "--exclude=false" "--batch") 0) (notmuch-logged-error "notmuch count --batch failed" "Please check that the notmuch CLI is new enough to support `count diff --git a/test/T440-emacs-hello.sh b/test/T440-emacs-hello.sh index d9d28f8e..842781a4 100755 --- a/test/T440-emacs-hello.sh +++ b/test/T440-emacs-hello.sh @@ -68,7 +68,7 @@ test_emacs '(notmuch-hello) notmuch tag -$tag '*' test_expect_equal_file $EXPECTED/notmuch-hello-long-names OUTPUT -test_begin_subtest "All Tags show up" +test_begin_subtest "All tags show up" tag=exclude_me notmuch tag +$tag '*' notmuch config set search.exclude_tags $tag