unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>,
	Gregor Zattler <telegraph@gmx.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/3] test/emacs: add known broken test for hidden tags
Date: Thu, 20 Jan 2022 15:49:41 -0400	[thread overview]
Message-ID: <874k5ygpbe.fsf@tethera.net> (raw)
In-Reply-To: <20220105010606.2034601-1-david@tethera.net>

David Bremner <david@tethera.net> writes:

> Gregor Zattler observed that tags could be unintentionally hidden in
> the "All tags" view, and Tomi Ollia worked out [2] that the issue was tags
> that only occured on excluded messages. This test reproduces that bug.
>
> [1]: id:87wox1vovj.fsf@len.workgroup
> [2]: id:m28t9faaim.fsf@guru.guru-group.fi

Applied the series to master, with two trivial changes: one to
indentation, one to capitalization.

Interdiff follows.

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index cd7ac39c..9ac52c11 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -570,7 +570,7 @@ options will be handled as specified for
 					    (plist-get options :filter))))
 	 "\n")))
     (unless (= (notmuch--call-process-region (point-min) (point-max) notmuch-command
-				    t t nil "count" "--exclude=false" "--batch") 0)
+					     t t nil "count" "--exclude=false" "--batch") 0)
       (notmuch-logged-error
        "notmuch count --batch failed"
        "Please check that the notmuch CLI is new enough to support `count
diff --git a/test/T440-emacs-hello.sh b/test/T440-emacs-hello.sh
index d9d28f8e..842781a4 100755
--- a/test/T440-emacs-hello.sh
+++ b/test/T440-emacs-hello.sh
@@ -68,7 +68,7 @@ test_emacs '(notmuch-hello)
 notmuch tag -$tag '*'
 test_expect_equal_file $EXPECTED/notmuch-hello-long-names OUTPUT
 
-test_begin_subtest "All Tags show up"
+test_begin_subtest "All tags show up"
 tag=exclude_me
 notmuch tag +$tag '*'
 notmuch config set search.exclude_tags $tag

  parent reply	other threads:[~2022-01-20 19:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 16:12 Bug? notmuch-emacs: "All tags" in notmuch-hello does not show all tags Gregor Zattler
2018-04-21 17:38 ` Tomi Ollila
2018-04-21 22:33   ` Gregor Zattler
2018-04-22  8:52     ` Tomi Ollila
2022-01-05  1:06       ` [PATCH 1/3] test/emacs: add known broken test for hidden tags David Bremner
2022-01-05  1:06         ` [PATCH 2/3] emacs: use --exclude=false when checking for empty searches David Bremner
2022-01-05  1:06         ` [PATCH 3/3] emacs: use --exclude=false when counting total messages David Bremner
2022-01-05 11:41           ` David Bremner
2022-01-20 19:49         ` David Bremner [this message]
2022-01-20 19:51       ` Bug? notmuch-emacs: "All tags" in notmuch-hello does not show all tags David Bremner
2022-01-22 14:14         ` confirm bug fixed (was: Bug? notmuch-emacs: "All tags" in notmuch-hello does not show all tags) Gregor Zattler
2022-01-22 15:25           ` David Bremner
2022-01-22 17:44             ` Attempt 2 to fix the all-tags display with excludes David Bremner
2022-01-22 17:44               ` [PATCH 1/2] Revert "emacs: use --exclude=false when checking for empty searches" David Bremner
2022-01-22 17:44               ` [PATCH 2/2] emacs: define, use option :disable-excludes for n-h-query-counts David Bremner
2022-01-23 19:00                 ` David Bremner
2022-01-23 19:36                   ` Gregor Zattler
2022-01-24  2:54                     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k5ygpbe.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=telegraph@gmx.net \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).