From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id IG4ENp0nomaIKgEAqHPOHw:P1 (envelope-from ) for ; Thu, 25 Jul 2024 10:23:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id IG4ENp0nomaIKgEAqHPOHw (envelope-from ) for ; Thu, 25 Jul 2024 12:23:26 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=tethera.net header.s=2024 header.b=RilHIDKy; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721903004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=DE91pelIOMT74YD9WUcUbkaVKUuKSL1JiYscJo4AJG0=; b=aAoxuKeCr1W8lTVIn2j26JTWhLTq4PdRoXQ1KuFEWM0vDF6tKd4UiYz7mTv576FlRK3cXB Qatlfw9NwvQTzVJnQX/05RKaUSgGXKJmAQKCIQEkrJzGwBrg7NDqdWPeW8L6a3FxBhBEHr n8foZwis9Y+xAHZge81ahFmkAT01Q3Mtvg+ryZxwWTp8KU5LOn5RQ0ktotBM9dfFDXe0vT c8FZhmujjCstp87U/QYni7ZLug4yIuTH0Pz3nAg8ZUYbcy3PTnUEUXH4jrbABhkoCDq0F6 NKhwCIUsibhqWgAFNdy7JhTstbaEjIjs65CgW+ldqxzY51ZwnJptx/XDkaMobg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=tethera.net header.s=2024 header.b=RilHIDKy; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721903004; a=rsa-sha256; cv=none; b=ZpQ6i65yOyR1BLjVNlSXY/kj8ZmAv9iJEkJH1R4qegESLG4tdVptH/xcmxDhnGCY8c9I31 QHWcxVButh28QIO7vXxvVFOkFNPSipXJxvEexkl6XKSIcDtiz2WoGO30xadcsSnFmKczCF +wh+osLjQRVwacgg07ZlYM21AL24cQslIWBtGXryW/tM7A+gSJ3IS/QzqAocunQS28YlV1 1d1iV+VCVLA2E1ccD58KOv24pNxbmDR+HeRaZWw8iNf2ZFSnHOPvtE4a+cvvA69EGRYE4g G/YaAq7YA+/4Uykne+k+vg8/oFVwwax5A+ywxJTPdRtvFpetJqibC9ZLBe6c4A== Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2A13651E7A for ; Thu, 25 Jul 2024 12:23:24 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 77C385F4A5; Thu, 25 Jul 2024 10:23:15 +0000 (UTC) Received: from phubs.tethera.net (phubs.tethera.net [192.99.9.157]) by mail.notmuchmail.org (Postfix) with ESMTPS id 4C2485E50E for ; Thu, 25 Jul 2024 10:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tethera.net; i=@tethera.net; q=dns/txt; s=2024; t=1721902990; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=UoMLxf6lFnQwq6az5GeU6uogh/1L9OSHXLmEDvPAsB4=; b=RilHIDKyXTgyvhGc1Wc/zhKj53Ywk2V1SV33/x0nL3nUyKHJstjOu0Gcey4kKJd0xLvEO CAM8746pnMEz0c6y4fYo30e+5kBVFZ4XNnhf1Y0+6/um8QRa6fy9GGT/Z2VIdR45eQlm8xb V7ieT3ggid/Pjuxdz6Q8z34kglhaNS+DJal5R7lZU7VPXTlCxBKkRevpDXeIucgVJ9Zbuom lbGovxsAxcsoMJxv92wbJ2uZIg8TVatoUkXScNoHVLtjImlAapun58NTmKtRXCqzttAghKd cXfmD9JPi/otkMnv7SNydhLFOilXnlLqt7ngV0+sdDpZ4P4MFpmgyHoFw1Ng== Received: from tethera.net (unknown [210.110.131.58]) by phubs.tethera.net (Postfix) with ESMTPS id 3950118006E; Thu, 25 Jul 2024 07:23:08 -0300 (ADT) Received: (nullmailer pid 353860 invoked by uid 1000); Thu, 25 Jul 2024 10:23:05 -0000 From: David Bremner To: Kevin Boulain , notmuch@notmuchmail.org Subject: Re: [PATCH v2 2/2] lib: thread-safe s-expression query parser In-Reply-To: <20230827123103.22744-2-kevin@boula.in> References: <87fs5fg40h.fsf@tethera.net> <20230827123103.22744-2-kevin@boula.in> Date: Thu, 25 Jul 2024 19:23:05 +0900 Message-ID: <874j8dkbxy.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: ULFQDSCKM2I4RXRPGZOSMLW43CNS4VGY X-Message-ID-Hash: ULFQDSCKM2I4RXRPGZOSMLW43CNS4VGY X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kevin Boulain X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 2A13651E7A X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -2.06 X-Spam-Score: -2.06 X-TUID: PzhIe4m+FXsQ Kevin Boulain writes: > Follow-up of 6273966d, now that sfsexp 1.4.1 doesn't rely on globals > anymore by default (https://github.com/mjsottile/sfsexp/issues/21). > > This simply defers the initial query generation to use the thread-safe > helper (xapian_query_match_all) instead of Xapian::Query::MatchAll. I squashed to the two commits together, so the test is now more like a regression test. While the testing situation is not ideal, this is an improvement on the status quo, so I've applied the change to master.