unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Carl Worth <cworth@cworth.org>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: Better handling of stdout and stderr
Date: Wed, 10 Nov 2010 16:25:49 -0800	[thread overview]
Message-ID: <8739r8bt9u.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <87k4kkq3r2.fsf@yoom.home.cworth.org>

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

On Wed, 10 Nov 2010 13:15:45 -0800, Carl Worth <cworth@cworth.org> wrote:
> Meanwhile, I've just now pushed out my little test-lib.sh change, so you
> can update the patch for that as well.

Oh, and one other thing I forgot to mention about the patch. It
currently talks about things along the lines of "git-style tests" and
"cworth-style tests".

You and I might understand perfectly well what that means now, but we
need the test suite to be independently comprehensible. (I'd like to be
able to understand it myself when I look at it again in the future,
having forgotten the current history.)

So if you could describe these instead as something like "tests using
test_expect_success" vs. "tests using
test_begin_subtest/test_expect_equal" or something like that, that would
be great.

Thanks again,

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2010-11-11  0:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09 23:40 [PATCH] test: Better handling of stdout and stderr Michal Sojka
2010-11-10 21:15 ` Carl Worth
2010-11-11  0:25   ` Carl Worth [this message]
2010-11-11 15:57     ` Michal Sojka
2010-11-14 21:52     ` Michal Sojka
2010-11-14 21:54       ` [PATCH 1/5] " Michal Sojka
2010-11-14 21:54       ` [PATCH 2/5] test: Add trailing newline to error messages Michal Sojka
2010-11-14 21:54       ` [PATCH 3/5] test: Break on test script (or other) error Michal Sojka
2010-12-07 23:33         ` Carl Worth
2010-12-08 14:28           ` Michal Sojka
2010-11-14 21:54       ` [PATCH 4/5] test: Detect unfinished subsets Michal Sojka
2010-11-14 21:54       ` [PATCH 5/5] test: Fix bugs detected thanks to the previous commit Michal Sojka
2010-11-16 19:32       ` [PATCH] test: Better handling of stdout and stderr Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739r8bt9u.fsf@yoom.home.cworth.org \
    --to=cworth@cworth.org \
    --cc=notmuch@notmuchmail.org \
    --cc=sojkam1@fel.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).