From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.
Date: Wed, 15 Jun 2011 18:25:14 +0400 [thread overview]
Message-ID: <8739jbqiid.fsf@gmail.com> (raw)
In-Reply-To: <87sjrbkx3j.fsf@yoom.home.cworth.org>
On Wed, 15 Jun 2011 07:06:40 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > I have just send two more patches to this thread. One with new tests.
> > Another with a workaround for the bug. The workaround should not break
> > anything since it affects only notmuch-show mode.
>
> Thanks!
>
> I love committing tests that demonstrate broken code before committing
> fixes. As it happened here, I committed these two new patches thinking I
> had previously committed the earlier patches in the series. Fortunately,
> the failure of the test pointed out that I was missing the actual fix.
>
I know you prefer tests to go before patches and I agree with that. But
most of the time I do tests after coding. I do not know an easy way to
reorder patches in git. (Also I do not know how to amend an old patch,
wish more darcs features in git.) Hopefully it is not a big trouble for
you to reorder the patches when applying.
> I also really like the workaround to avoid regressing functionality
> because of an emacs bug.
>
indeed
> Well done, Dmitry. I've now pushed out everything in this series.
>
Thanks.
Regards,
Dmitry
> -Carl
>
> --
> carl.d.worth@intel.com
next prev parent reply other threads:[~2011-06-15 14:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 22:10 [PATCH] Fix hiding a message while some citations are visible Dmitry Kurochkin
2011-05-25 22:10 ` [PATCH 1/5] Pass message to the `notmuch-show-insert-text/plain-hook' hook Dmitry Kurochkin
2011-05-25 22:10 ` [PATCH 2/5] Set message invisibility spec properties before inserting the body Dmitry Kurochkin
2011-05-25 22:10 ` [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view Dmitry Kurochkin
2011-05-25 22:23 ` Carl Worth
2011-05-25 22:34 ` Dmitry Kurochkin
2011-05-25 22:46 ` Carl Worth
2011-05-25 23:10 ` Dmitry Kurochkin
2011-05-26 1:02 ` Carl Worth
2011-05-26 10:26 ` Dmitry Kurochkin
2011-05-26 21:31 ` Carl Worth
2011-05-26 21:42 ` Dmitry Kurochkin
2011-06-15 14:06 ` Carl Worth
2011-06-15 14:25 ` Dmitry Kurochkin [this message]
2011-06-15 16:16 ` Jameson Graef Rollins
2011-06-15 17:00 ` Carl Worth
2011-06-15 17:10 ` Dmitry Kurochkin
2011-05-25 22:10 ` [PATCH 4/5] Set higher priority for headers and hidden citation overlays Dmitry Kurochkin
2011-05-25 22:10 ` [PATCH 5/5] Simplify message and headers visibility code in notmuch-show view Dmitry Kurochkin
2011-05-26 21:38 ` [PATCH 1/2] test: add tests for hiding messages " Dmitry Kurochkin
2011-05-26 21:38 ` [PATCH 2/2] Workaround for Emacs bug #8721 Dmitry Kurochkin
2011-05-26 21:48 ` Dmitry Kurochkin
2011-05-28 1:29 ` Dmitry Kurochkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739jbqiid.fsf@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).