From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bremner@unb.ca>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 5B84E429E21
	for <notmuch@notmuchmail.org>; Mon,  3 Oct 2011 18:11:05 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.3
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 1mRBjvDxpIP2 for <notmuch@notmuchmail.org>;
	Mon,  3 Oct 2011 18:11:04 -0700 (PDT)
Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id AAB61431FB6
	for <notmuch@notmuchmail.org>; Mon,  3 Oct 2011 18:11:04 -0700 (PDT)
Received: from zancas.localnet
	(fctnnbsc36w-156034064058.pppoe-dynamic.High-Speed.nb.bellaliant.net
	[156.34.64.58]) (authenticated bits=0)
	by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p941AwDX015922
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
	Mon, 3 Oct 2011 22:10:59 -0300
Received: from bremner by zancas.localnet with local (Exim 4.76)
	(envelope-from <bremner@unb.ca>)
	id 1RAtX8-0001wc-Gg; Mon, 03 Oct 2011 22:10:58 -0300
From: David Bremner <david@tethera.net>
To: Ali Polatel <polatel@gmail.com>, Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH] lib: make find_message{,by_filename) report errors
In-Reply-To: <cover.1317456435.git.alip@exherbo.org>
References: <20110930064712.GA30012@hayalet>
	<cover.1317456435.git.alip@exherbo.org>
User-Agent: Notmuch/0.9~rc1 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 03 Oct 2011 22:10:58 -0300
Message-ID: <8739f9muhp.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Notmuch Mailing List <notmuch@notmuchmail.org>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2011 01:11:05 -0000

On Sat,  1 Oct 2011 11:12:23 +0300, Ali Polatel <polatel@gmail.com> wrote:
> From: Ali Polatel <alip@exherbo.org>
>=20
> Looks like the patch did not make it correctly the first time.
> Resending using git-send-email=E2=84=A2
>=20
> You may also find the commit in my notmuch repository:
> git://github.com/alip/notmuch.git branch: find_message


Hi Ali;

Thanks for reworking this patch. I looked at branch find_message-v2
in your repo. I have a few comments.

- In the comments for _resolve_message_id_to_thread_id I guess thread_id
  should be thread_id_ret?

- in notmuch_database_find_message_by_file_name, I'm not sure why you
  set status to NOTMUCH_STATUS_OUT_OF_MEMORY in the catch block. Is this
  a typo?

- after the DONE: label of the same routine, how is *message_ret destroyed?
  does it need to wait until the talloc context "notmuch" is freed?

- I don't really get the change of user to caller around notmuch.h:286
  It is not a big deal, but I guess we should try to be consistent.

David

=20