From: Thomas Schwinge <thomas@schwinge.name>
To: Daniel Schoepe <daniel.schoepe@googlemail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Turn id:"<message-id>" elements into buttons for notmuch searches
Date: Mon, 17 Oct 2011 11:16:45 +0200 [thread overview]
Message-ID: <8739es0ygy.fsf@kepler.schwinge.homeip.net> (raw)
In-Reply-To: <1309961881-28333-2-git-send-email-daniel.schoepe@googlemail.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
Hi!
Good idea!
On Wed, 6 Jul 2011 16:18:01 +0200, Daniel Schoepe <daniel.schoepe@googlemail.com> wrote:
> +(defun notmuch-show-buttonise-links (start end)
> + "Buttonise URLs and mail addresses between START and END.
> +
> +This also turns id:\"<message id>\"-parts into buttons for
> +a corresponding notmuch search."
> + (goto-address-fontify-region start end)
> + (save-excursion
> + (goto-char start)
> + (while (re-search-forward "id:\"[^ ]+\"" end t)
Is it permissible for message IDs to contain double quotes? If not (and
I hope so), might id:\"[^\"]+\" be a better regexp? (Untested.) As it
appears to me, this would allow proper matching in text like this, too:
Bla bla, see id:"some@thing". Bla bla.
Even if not favorable, should a syntax without double quotes be
supported, too? Here we'd really have to match on whitespace and line
end, as everything else is too ambiguous.
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
next prev parent reply other threads:[~2011-10-17 9:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 20:12 [PATCH] emacs: Turn id:"<message-id>" elements into buttons for notmuch searches Daniel Schoepe
2011-07-06 14:18 ` [PATCH v2] emacs: Turn id:"<message-id>" elements into buttons for Daniel Schoepe
2011-07-06 14:18 ` [PATCH v2] emacs: Turn id:"<message-id>" elements into buttons for notmuch searches Daniel Schoepe
2011-07-07 7:04 ` Pieter Praet
2011-07-07 7:16 ` Dmitry Kurochkin
2011-07-07 8:07 ` Pieter Praet
2011-07-07 8:15 ` Daniel Schoepe
2011-07-07 8:22 ` Dmitry Kurochkin
2011-10-11 14:27 ` Daniel Schoepe
2011-10-17 9:16 ` Thomas Schwinge [this message]
2011-10-17 12:13 ` Daniel Schoepe
2011-10-17 13:11 ` Thomas Schwinge
2011-10-17 13:43 ` Daniel Schoepe
2011-10-28 14:48 ` [PATCH v3] emacs: Turn id:"<message-id>" elements into buttons for Daniel Schoepe
2011-10-28 14:48 ` [PATCH v3] emacs: Turn id:"<message-id>" elements into buttons for notmuch searches Daniel Schoepe
2011-10-28 17:21 ` [PATCH v3] emacs: Turn id:"<message-id>" elements into buttons for David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739es0ygy.fsf@kepler.schwinge.homeip.net \
--to=thomas@schwinge.name \
--cc=daniel.schoepe@googlemail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).