From: Mark Walters <markwalters1009@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
notmuch@notmuchmail.org
Subject: Re: [RFC PATCH v5 00/11] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag
Date: Wed, 15 Feb 2012 21:11:15 +0000 [thread overview]
Message-ID: <8739aber9o.fsf@qmul.ac.uk> (raw)
In-Reply-To: <8739acrnu7.fsf@servo.finestructure.net>
On Wed, 15 Feb 2012 09:46:56 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Wed, 15 Feb 2012 09:03:28 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> > The current implementation of exclude-tags does not use excludes in
> > notmuch-show.c (and thus not in notmuch-show.el). Thus when selecting
> > a thread in the search view claiming one matched message you may get
> > several matches in show all but one of which are tagged excluded.
>
> Hey, Mark. Thanks so much for working on this. This is a very nice
> extension to Austin's work.
>
> > This set moves in a different direction. It returns all the results
> > but marks excluded messages with a new flag
> > (NOTMUCH_MESSAGE_FLAG_EXCLUDED) and lets the consumer decide what to
> > do with them. For example it could start with the message closed in
> > emacs show view, it could colour the headerline differently etc.
>
> I missed some of the previous discussion on this, but rather than add a
> new flag, why not just use the existing "match" flag? If the message is
> excluded, just mark "match" as "false". I think this is basically all
> we really want. If the message is "excluded" include it in returned
> threads, but just don't display it. This is in fact exactly what the
> "match" flag is currently for, and I can't see any reason not to use it
> here. We don't need to add anything new to the show output, and I
> believe it will simplify this patch set considerably.
I think the difficulty is that there are lots of annoying corner cases,
but if there is a simpler solution that would be great!
Anyway I will mention a couple of corner cases I can remember with any
thoughts I have on alternative solutions.
1) What should notmuch show id:deleted-message-id do?
It could return the thread containing the deleted message. If it does
return a thread what subject does it assign it? Possibly it could
return no messages and the caller would have to call it again with
--no-exclude.
2) Should notmuch search return threads which match but only in excluded
messages?
If yes then does it sort it based on match or match-not-excluded? If the
latter what happens to threads with no match-not-excluded messages? If
not then does searching for id:deleted-message return no results? The
caller could try with --no-exclude, but then the caller would end up
returning the deleted message for search id:deleted-message but not for
search id:deleted-message or id:some-other-not-deleted-message.
Anyway with answers to the 2 main questions I can try thinking about
simpler possibilities.
Best wishes
Mark
next prev parent reply other threads:[~2012-02-15 21:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 9:03 [RFC PATCH v5 00/11] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag Mark Walters
2012-02-15 9:03 ` [RFC PATCH v5 01/11] cli: add --no-exclude option to count and search Mark Walters
2012-02-24 23:03 ` Austin Clements
2012-02-15 9:03 ` [RFC PATCH v5 02/11] cli: Add --no-exclude to the man pages for search and count Mark Walters
2012-02-24 23:05 ` Austin Clements
2012-02-15 9:03 ` [RFC PATCH v5 03/11] test: add tests for new cli --no-exclude option Mark Walters
2012-02-15 9:03 ` [RFC PATCH v5 04/11] lib: Rearrange the exclude code in query.cc Mark Walters
2012-02-15 9:03 ` [RFC PATCH v5 05/11] lib: Make notmuch_query_search_messages set the exclude flag Mark Walters
2012-02-24 23:39 ` Austin Clements
2012-02-15 9:03 ` [RFC PATCH v5 06/11] lib: Add the exclude flag to notmuch_query_search_threads Mark Walters
2012-02-15 9:03 ` [RFC PATCH v5 07/11] cli: Make notmuch-show respect excludes Mark Walters
2012-02-15 9:03 ` [RFC PATCH v5 08/11] man: update manpage for notmuch-show --no-exclude option Mark Walters
2012-02-24 23:44 ` Austin Clements
2012-02-15 9:03 ` [RFC PATCH v5 09/11] test: update tests to reflect the exclude flag Mark Walters
2012-02-24 23:47 ` Austin Clements
2012-02-15 9:03 ` [RFC PATCH v5 10/11] cli: omit excluded messages in results where appropriate Mark Walters
2012-02-15 9:03 ` [RFC PATCH v5 11/11] emacs: show: recognize the exclude flag Mark Walters
2012-02-15 17:46 ` [RFC PATCH v5 00/11] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag Jameson Graef Rollins
2012-02-15 18:10 ` Jameson Graef Rollins
2012-02-15 21:11 ` Mark Walters [this message]
2012-02-15 22:16 ` Jameson Graef Rollins
2012-02-15 23:59 ` Austin Clements
2012-02-16 0:30 ` Mark Walters
2012-02-24 23:58 ` Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739aber9o.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).