From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1FB58431FBC for ; Sat, 10 Mar 2012 17:19:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9k6Oc3oimzQY for ; Sat, 10 Mar 2012 17:19:43 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 006A1431FAE for ; Sat, 10 Mar 2012 17:19:42 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 1747C66E011C; Sat, 10 Mar 2012 17:19:40 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com [76.174.137.84]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 4EB6966E00F8; Sat, 10 Mar 2012 17:19:36 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id C4646506; Sat, 10 Mar 2012 17:19:35 -0800 (PST) From: Jameson Graef Rollins To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 0/5] Move to --with-excluded approach to excludes In-Reply-To: <1330779918-28024-1-git-send-email-markwalters1009@gmail.com> References: <1330779918-28024-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.11.1+266~gadb05cc (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 10 Mar 2012 17:19:33 -0800 Message-ID: <87399g7x3u.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Mar 2012 01:19:45 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Sat, 3 Mar 2012 13:05:13 +0000, Mark Walters wrote: > This series implements the proposal in id:"87y5riuz7v.fsf@qmul.ac.uk" > to move to a consistent --with-excluded approach rather than the > previous --no-exclude approach. See the message there and its > descendants for discussion. >=20 > The main user side change is that notmuch-search no longer defaults to > showing all the excluded threads with [0/n] but will do so if the user > says they want all the messages (i.e., by specifying --with-excluded). >=20 > However, it makes everything consistent throughout the commandline and > lib interfaces. In all cases a "message" type search only returns the > non-excluded matches (unless --with-excluded is specified) and a > "thread" type search returns all messages (including excluded ones) in > threads that match in a non-excluded message. Hi, Mark. Thanks so much for working on this. This new solution seems like a good one. It keeps the default as expected (excluded are actually excluded from all output), and the with-excluded option behaves intuitively. Looks good to me. Unfortunately, as I discussed with you on irc today, there seems to be a problem with the patch series that is preventing it from working as expected. The outputs of the following commands should agree, which they do: servo:~/src/notmuch/git [master] 0$ ./notmuch count --with-excluded tag:inb= ox 51171 servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages --= with-excluded tag:inbox | wc -l 51171 servo:~/src/notmuch/git [master] 0$=20 However, they should also agree in this case, which they don't: servo:~/src/notmuch/git [master] 0$ ./notmuch count tag:inbox 115 servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages ta= g:inbox | wc -l 51169 servo:~/src/notmuch/git [master] 0$=20 In this last case, notmuch search is outputting (some but not all(!)) excluded messages when it shouldn't be. However, if I use a more complicated search term, everything seems to be working fine: servo:~/src/notmuch/git [master] 0$ ./notmuch count tag:inbox and tag:unread 0 servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages ta= g:inbox and tag:unread | wc -l 0 servo:~/src/notmuch/git [master] 0$ ./notmuch count --with-excluded tag:inb= ox and tag:unread 47245 servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages --= with-excluded tag:inbox and tag:unread | wc -l 47245 servo:~/src/notmuch/git [master] 0$=20 It also works if I give a single "from:" search term instead of a single "tag:" search term. So it appears to be something about how the excluded query is constructed. I can't figure out where the problem is, although I'm still looking. If anyone else can figure it out, please let us know. I would really like to get this series applied so that I can get back to following master! Thanks again for all the work. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPW/2lAAoJEO00zqvie6q8miAP/AyFCGUrvf1l2mlDLizt9x8I h9q+1c6JFDuGU6x18pSgHxEuKqjuIKvz/OC0ikwTocSKRhEXuzLKYa4NXkxVPM3M e8jxFLc9dJ/X6QSla22ATGnd403xVLGplvWCAOgsQABbuZ4JB5b5NxlG9+vbLP3A NRDCS4TrYzLi0qbL+C9H268+Bb+GqANnkHDtvVnti0M3Uhdor8w+ZWebChR3/gkA 4rUEcgPEgpBllkpQph/SXIrtEK1uKL20R2rA1CKN8EPShTrCDR1YEW0vJpXAvT6I +ZaNfL4Crn+D899dUhMI2visOJwn+JqmuQBca7z1guv04MsUqQOmrt+VQ3s9odUy rRqhh0bPEwb1euWwh5oN602AdgmFG90/21Xm2iWWq2c9jmko21OTHBodYGTSCZb5 SDJIkmadIWUpiRm176aC0+VA2izDk4e1Th04gQ1GqjhywCus8NPTZoO9thDYyTUv fY3eok9ILIz+0M3S/7zUy/NSGKVMYAGizM5txfaONPQO4qn9eu6A0TWsBtO+26f/ UKAcjMlv2+WVK8W8RhxQk188PpTAfYW3r0z1u3lSxfUegOJpcqYYfY7ul+riK1WF tQ0zly4VgTzBZgpNcc81ap62iUKf+Ph0CUG/rJDao31hrIGoIgonHT+Wd+0dmFcj Thc65LIQZZETnW8sE0MK =Fh3j -----END PGP SIGNATURE----- --=-=-=--