From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1DE03431FCB for ; Wed, 23 May 2012 18:53:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o+thp8fpcuCQ for ; Wed, 23 May 2012 18:53:31 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id C5CE7431FC4 for ; Wed, 23 May 2012 18:53:31 -0700 (PDT) Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.89.108] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1SXNF4-0006hj-KQ; Wed, 23 May 2012 22:53:30 -0300 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1SXNEz-0005CZ-BH; Wed, 23 May 2012 22:53:25 -0300 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory_create In-Reply-To: <1337314423-3702-2-git-send-email-amdragon@mit.edu> References: <1337314423-3702-1-git-send-email-amdragon@mit.edu> <1337314423-3702-2-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.13 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Wed, 23 May 2012 22:53:25 -0300 Message-ID: <87396q1h0q.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2012 01:53:32 -0000 Austin Clements writes: > Previously this function would create directory documents if they > didn't exist. As a result, it could only be used on writable > databases. This adds an argument to make creation optional and to > make this function work on read-only databases. We use a flag > argument to avoid a bare boolean and to permit future expansion. Series pushed, d PS. I marked a couple other of your patches stale in nmbug.