From: James Vasile <james@hackervisions.org>
To: Austin Clements <amdragon@MIT.EDU>
Cc: notmuch mailing list <notmuch@notmuchmail.org>
Subject: Re: [PATCH] don't show x-foo tags in search view
Date: Tue, 30 Oct 2012 10:57:27 -0400 [thread overview]
Message-ID: <87390w57oo.fsf@hackervisions.org> (raw)
In-Reply-To: <20121030005700.GE15377@mit.edu>
[-- Attachment #1: Type: text/plain, Size: 4227 bytes --]
Austin,
Thanks for the helpful comments. I redid the patch to take a list of
regexps. That way users can banish different kinds of tags or simply
list the tags themselves. I've responded to your comments in text below
the patch.
---
emacs/notmuch.el | 26 +++++++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index f9454d8..05aa114 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -775,6 +775,21 @@ non-authors is found, assume that all of the authors match."
(overlay-put overlay 'isearch-open-invisible #'delete-overlay)))
(insert padding))))
+
+(defcustom notmuch-search-hide-tag-regexps '()
+ "List of regular expressionss specifying tags to hide in search view.
+
+Notmuch will hide any tags in search view that match the regexps
+specified in the list `notmuch-search-hide-tag-regexp`. The
+match is case-insensitive.
+
+If you are not comfortable with regular expressions, a list of
+tag words will work, assuming those tags use only alphanumeric
+characters. An empty list will disable hiding of tags in search
+view. The list can be set via setq or the customize interface."
+ :type '(repeat regexp)
+ :group 'notmuch-search)
+
(defun notmuch-search-insert-field (field format-string result)
(cond
((string-equal field "date")
@@ -793,7 +808,16 @@ non-authors is found, assume that all of the authors match."
(notmuch-search-insert-authors format-string (plist-get result :authors)))
((string-equal field "tags")
- (let ((tags-str (mapconcat 'identity (plist-get result :tags) " ")))
+ (let ((tags-str
+ (mapconcat 'identity
+ (let ((case-fold-search t))
+ (remove-if
+ (lambda (tag)
+ (find tag notmuch-search-hide-tag-regexps
+ :test (lambda (tag regexp)
+ (string-match regexp tag))))
+ (plist-get result :tags)))
+ " ")))
(insert (propertize (format format-string tags-str)
'face 'notmuch-tag-face))))))
--
1.7.10.4
Austin Clements <amdragon@MIT.EDU> writes:
> I like it.
Thanks.
[snip]
> I have no idea why, but Emacs typically uses "regexp" instead of
> "regex".
It probably has something to do with rhyming with 'sexp'. ;) It's good
to conform to the vernacular, so I fixed it.
>
>> +
>> +Leave blank to disable hiding of tags in search view.
>
> Saying "Leave blank" supposes that the user knows what the default
> value is. How about "An empty string disables hiding of tags in
> search view."?
I'm now using a list, but yes, "an empty list" is a good way to describe
it.
>
> Even better, though, would be to use nil to indicate this, since "" is
> a perfectly valid regexp and matches everything. In that case, this
> should say something like "If nil, no tags will be hidden in search
> view."
"An empty list" is nil, so I think this is covered by my changes. If
you think the defcustom text could be clearer, I'd appreciate edits.
>
>> +Note: elisp regexes are case-insensitive"
>
> Likewise, "regexps". Also, Elisp regexps are not, in general,
> case-insensitive. If we want to control this, we should bind
> case-fold-search to nil around the string-match below and say
> something here like "Matching is case-insensitive."
Good point.
>
>> + :type 'string
>
> Better would be 'regexp. Or, '(choice (const :tag "None" nil) regexp)
> to allow nil or a regexp.
Changed to 'regexp.
[snip]
> It would be simpler and more robust to use remove-if here. What about
> something like
>
> (let ((tags-str
> (mapconcat 'identity
> (if notmuch-search-hide-tag-regex
> (let ((case-fold-search t))
> (remove-if
> (apply-partially #'string-match
> notmuch-search-hide-tag-regex)
> (plist-get result :tags)))
> (plist-get result :tags))
> " ")))
That's a good idea. I adjusted the code to use remove-if, and it is
improved by the change.
Thanks,
James
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
next prev parent reply other threads:[~2012-10-30 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 18:57 [PATCH] don't show x-foo tags in search view James Vasile
2012-10-29 19:22 ` David Bremner
2012-10-29 19:47 ` James Vasile
2012-10-29 21:19 ` James Vasile
2012-10-30 0:57 ` Austin Clements
2012-10-30 14:57 ` James Vasile [this message]
2012-11-07 12:44 ` David Bremner
2012-11-07 14:15 ` James Vasile
2012-11-07 14:37 ` Austin Clements
2012-10-30 9:41 ` Damien Cassou
2012-10-30 16:42 ` James Vasile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87390w57oo.fsf@hackervisions.org \
--to=james@hackervisions.org \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).