unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Eirik Byrkjeflot Anonsen <eirik@eirikba.org>, notmuch@notmuchmail.org
Subject: Re: Automatic suppression of non-duplicate messages
Date: Sat, 03 Nov 2012 16:53:19 -0400	[thread overview]
Message-ID: <87390qxvb4.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <87mwyz3s9d.fsf@star.eba>

Eirik Byrkjeflot Anonsen <eirik@eirikba.org> writes:

> That's not what I see.  If I search for a term that only appears in
> one of the "copies", none of the copies are included in the search
> result.

The offending code is at line 1813 of lib/database.cc; the message is
only indexed if the message-id is new.

It might be sensible to move _notmuch_message_index_file into the other
branch of the if, but even if that works fine, something more
sophisticated is needed for the call to
__notmuch_message_set_header_values; the invariant that each message has
a single subject seems reasonable.

Offhand I'm not sure of a good method of automatically deciding what is
the same message (with e.g. headers and footer text added by a mailing
list).

  reply	other threads:[~2012-11-03 20:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-03 10:17 Automatic suppression of non-duplicate messages Eirik Byrkjeflot Anonsen
2012-11-03 20:53 ` David Bremner [this message]
2012-11-04 10:06   ` Eirik Byrkjeflot Anonsen
2012-11-04 22:34   ` Jani Nikula
2012-11-05  4:28     ` Austin Clements
2012-11-05 15:22     ` Eirik Byrkjeflot Anonsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87390qxvb4.fsf@maritornes.cs.unb.ca \
    --to=david@tethera.net \
    --cc=eirik@eirikba.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).