From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A0728431FC2 for ; Fri, 14 Dec 2012 21:52:11 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sMfk9Uh6pzA0 for ; Fri, 14 Dec 2012 21:52:11 -0800 (PST) Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU [18.9.25.14]) by olra.theworths.org (Postfix) with ESMTP id 1DAE0431FC0 for ; Fri, 14 Dec 2012 21:52:11 -0800 (PST) X-AuditID: 1209190e-b7f516d0000008e4-b4-50cc100a4438 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP id 6D.0B.02276.A001CC05; Sat, 15 Dec 2012 00:52:10 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id qBF5qA0P025753; Sat, 15 Dec 2012 00:52:10 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qBF5q8JB014033 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 15 Dec 2012 00:52:09 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) (envelope-from ) id 1TjkfQ-0007De-7b; Sat, 15 Dec 2012 00:52:08 -0500 From: Austin Clements To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v2 0/5] Use invisibility to toggle display of all parts including multipart In-Reply-To: <1355389924-3718-1-git-send-email-markwalters1009@gmail.com> References: <1355389924-3718-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.14+159~g6895fee (http://notmuchmail.org) Emacs/23.4.1 (i486-pc-linux-gnu) Date: Sat, 15 Dec 2012 00:52:08 -0500 Message-ID: <8738z7ooaf.fsf@awakening.csail.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsUixG6nosslcCbA4PBdQYvVc3ksrt+cyezA 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZSx7cJStYBt7xYoTv5kaGNvYuhg5OSQETCRW zb0MZYtJXLi3Hsjm4hAS2Mco8XjXRRYIZwOjRNeRO8wQzkUmidM/bzBCOEsYJeYu2cgO0s8m oC+xYu0kVhBbRMBV4um3z8wgtrBAvMSC/Z/BajgFPCU27pnK1MXIAdTsIXHnQxGIKQpUMvuc D0gFi4CqxKFeiE5eoOtOv33JCmELSpyc+YQFxGYW0JK48e8l0wRGgVlIUrOQpBYwMq1ilE3J rdLNTczMKU5N1i1OTszLSy3SNdbLzSzRS00p3cQICkdOSb4djF8PKh1iFOBgVOLh3RFxOkCI NbGsuDL3EKMkB5OSKO8uvjMBQnxJ+SmVGYnFGfFFpTmpxYcYJTiYlUR4xbYAlfOmJFZWpRbl w6SkOViUxHmvpNz0FxJITyxJzU5NLUgtgsnKcHAoSfDuARkqWJSanlqRlplTgpBm4uAEGc4D NPwrSA1vcUFibnFmOkT+FKOiFNBokIQASCKjNA+uF5YuXjGKA70izHsWpIoHmGrgul8BDWYC Ghx36TjI4JJEhJRUA2PY5LmcQZUHRFbOPLH98JesMEa5m+JsvLmmVbpnL69cYe2j8m3PLYk3 j271PMqKf+Pg6cFx48eE13cZEvtSt+R8NT/u+uZ9gMPtJm3hNVtZbRTF5fkjuxboCVhNMJ5u 5qNocXP15hjZ3m1u6pzHf01SY4o+pnfJ7es9XYYvRwWPz63bsumjfYASS3FGoqEWc1FxIgA1 8wG08gIAAA== X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2012 05:52:11 -0000 On Thu, 13 Dec 2012, Mark Walters wrote: > This is version 2 of the patch series (version 1 at > id:1354663662-20524-1-git-send-email-markwalters1009@gmail.com) > > Almost all of the changes and fixes are in response to Austin's > review. I have changed things as he suggested. > > There are two small extra tiny patches in this version: I set the > default value of notmuch-show-all-multipart/alternative-parts to nil. > > The second is to fix a bug reported by Jani: that fake-patch parts (as > provided by notmuch-wash) did not get hidden when the whole message > was hidden. This was due to notmuch-wash-convert-inline-patch-to-part > not passing a msg on down to notmuch-show-insert-bodypart. Previously > this did not matter but with with this series msg is needed to > construct the correct overlays. > > Best wishes > > Mark This series LGTM other than the few little things I pointed out.