From: Austin Clements <aclements@csail.mit.edu>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/5] Use invisibility to toggle display of all parts including multipart
Date: Sat, 15 Dec 2012 00:52:08 -0500 [thread overview]
Message-ID: <8738z7ooaf.fsf@awakening.csail.mit.edu> (raw)
In-Reply-To: <1355389924-3718-1-git-send-email-markwalters1009@gmail.com>
On Thu, 13 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This is version 2 of the patch series (version 1 at
> id:1354663662-20524-1-git-send-email-markwalters1009@gmail.com)
>
> Almost all of the changes and fixes are in response to Austin's
> review. I have changed things as he suggested.
>
> There are two small extra tiny patches in this version: I set the
> default value of notmuch-show-all-multipart/alternative-parts to nil.
>
> The second is to fix a bug reported by Jani: that fake-patch parts (as
> provided by notmuch-wash) did not get hidden when the whole message
> was hidden. This was due to notmuch-wash-convert-inline-patch-to-part
> not passing a msg on down to notmuch-show-insert-bodypart. Previously
> this did not matter but with with this series msg is needed to
> construct the correct overlays.
>
> Best wishes
>
> Mark
This series LGTM other than the few little things I pointed out.
prev parent reply other threads:[~2012-12-15 5:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 9:11 [PATCH v2 0/5] Use invisibility to toggle display of all parts including multipart Mark Walters
2012-12-13 9:12 ` [PATCH v2 1/5] emacs: show: modify insert-part-header to save the button text Mark Walters
2012-12-13 9:12 ` [PATCH v2 2/5] emacs: show: add overlays for each part Mark Walters
2012-12-15 5:39 ` Austin Clements
2012-12-13 9:12 ` [PATCH v2 3/5] emacs: show: add invisibility button action Mark Walters
2012-12-15 5:45 ` Austin Clements
2012-12-13 9:12 ` [PATCH v2 4/5] emacs: wash: fix fake-diff part to include msg parameter Mark Walters
2012-12-13 9:12 ` [PATCH v2 5/5] emacs: show: set default show-all-multipart/alternatives to nil Mark Walters
2012-12-15 5:52 ` Austin Clements [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738z7ooaf.fsf@awakening.csail.mit.edu \
--to=aclements@csail.mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).