From: Jani Nikula <jani@nikula.org>
To: Tomi Ollila <tomi.ollila@iki.fi>,
Karl Fogel <kfogel@red-bean.com>,
David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.
Date: Mon, 08 Apr 2013 10:40:23 +0200 [thread overview]
Message-ID: <8738v1jtzc.fsf@nikula.org> (raw)
In-Reply-To: <m2ppy5v3mc.fsf@guru.guru-group.fi>
On Mon, 08 Apr 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> The most tolerable way is to send new patch series w/ these 2 patches
> that apply cleanly on top of current master (661dcf87aeb70) so that the
> things that David needs to do are just to run `git am` and `make test`.
I'd say just squash the two together. We already have the old reverted
commit that doesn't build, let's not add another commit that breaks
bisect (= every commit must build, work, and pass tests).
BR,
Jani.
next prev parent reply other threads:[~2013-04-08 8:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 18:33 [PATCH] emacs: add missing paren to fix defun in notmuch-address.el Karl Fogel
2013-04-07 13:52 ` David Bremner
2013-04-07 21:50 ` Karl Fogel
2013-04-08 8:16 ` Tomi Ollila
2013-04-08 8:40 ` Jani Nikula [this message]
2013-04-08 10:50 ` David Bremner
2013-04-09 1:12 ` Jed Brown
2013-04-09 6:32 ` Tomi Ollila
2013-04-09 11:50 ` David Bremner
2013-04-09 12:12 ` Tomi Ollila
2014-07-04 0:38 ` Sebastian Lipp
2014-07-04 0:56 ` Karl Fogel
2014-07-04 9:25 ` Sebastian Lipp
2014-07-05 18:18 ` Karl Fogel
2014-07-06 20:41 ` Sebastian Lipp
2014-07-07 17:35 ` Karl Fogel
2014-07-06 20:37 ` Sebastian Lipp
2014-07-07 17:40 ` Karl Fogel
2014-07-08 8:56 ` Tomi Ollila
2014-07-08 17:59 ` Karl Fogel
2014-07-04 16:31 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738v1jtzc.fsf@nikula.org \
--to=jani@nikula.org \
--cc=david@tethera.net \
--cc=kfogel@red-bean.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).