From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, Jani Nikula <jani@nikula.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures
Date: Sun, 17 Nov 2013 07:34:57 -0400 [thread overview]
Message-ID: <8738mvz2fy.fsf@zancas.localnet> (raw)
In-Reply-To: <m28uwquccd.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> The log hook in it's current form is problematic as it doesn't provide
> way to distinguish progress reporting from error reporting.
Is this _more_ problematic than more output to stderr?
> Currently
> lib/database.cc writes error messages with fprintf(stderr, ...) everywhere.
Sure. But I'm trying to understand why a partial fix isn't better than
nothing. Is the argument just that the effort is wasted, or that the
result is somehow less satisfactory than the status quo.
> I suggest that this problem is fixed in one big sweep during 0.18
> development -- the suggestion Jani pastebin'd a few days ago is
> a good one and I'm willing to take part of that development...
> And now take this approach of fprintf()ing (basically I would
> also ask developers using the library wait for 0.18 before starting
> to use the compact functionality (if ever), as the we have yet
> another soname bump with changing interface coming...
I guess we can mark this interface as unstable for the moment?
"Asking developers not to use it" sounds pretty bad.
d
next prev parent reply other threads:[~2013-11-17 11:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 17:02 compactor adjustments v2 Tomi Ollila
2013-11-13 17:02 ` [PATCH v2 1/5] compact: tidy formatting Tomi Ollila
2013-11-13 17:02 ` [PATCH v2 2/5] compact: catch Xapian::Error consistently Tomi Ollila
2013-11-14 14:13 ` Jani Nikula
2013-11-18 0:33 ` David Bremner
2013-11-13 17:02 ` [PATCH v2 3/5] compact: preserve backup database until compacted database is in place Tomi Ollila
2013-11-14 14:08 ` Jani Nikula
2013-11-13 17:02 ` [PATCH v2 4/5] compact: unconditionally attempt to remove old wip database compact directory Tomi Ollila
2013-11-14 14:02 ` Jani Nikula
2013-11-13 17:02 ` [PATCH v2 5/5] compact: provide user more information on after-compaction failures Tomi Ollila
2013-11-14 14:13 ` Jani Nikula
2013-11-14 16:11 ` David Bremner
2013-11-14 17:23 ` Tomi Ollila
2013-11-17 11:34 ` David Bremner [this message]
2013-11-17 15:28 ` Tomi Ollila
2013-11-18 0:53 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738mvz2fy.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).