From: Mark Walters <markwalters1009@gmail.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el
Date: Sun, 26 Jan 2014 19:37:27 +0000 [thread overview]
Message-ID: <8738kaa614.fsf@qmul.ac.uk> (raw)
In-Reply-To: <87bnyzoqq9.fsf@zancas.localnet>
I don't have anything older than 23.4 anymore so I am afraid I can't
test. My recollection is that I upgraded to 23.4 the problem went away
so I forgot about it.
(I couldn't see easily what version of emacs debian stable has now as
seemed to be called 45.)
Best wishes
Mark
On Sat, 25 Jan 2014, David Bremner <david@tethera.net> wrote:
> Mark Walters <markwalters1009@gmail.com> writes:
>
>> ido-completing-read is used in notmuch-mua.el without any
>> initialization. This should work but a bug (emacs bug #3247) in some
>> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs
>> to get stuck in the mini-buffer. This tests to see if ido-mode has
>> been initialized and if not calls it. This avoids the bug for these
>> older versions of emacs.
>>
>> This is the only place that ido-completing-read is used so an alternative
>> would be to replace ido-completing-read by completing-read but cworth
>> expressed a preference for the ido version in
>> id:"87wrhfvk6a.fsf@yoom.home.cworth.
>
> This patch was tagged wip, but then there was no progress ;). It still
> applies cleanly, and doesn't seem to do any harm in emacs 23.4 nor
> emacs24.3. I don't have 23.2 at hand but I guess Tomi or Mark can
> confirm it actually fixes the bug there.
>
> I propose we either apply the patch or ::wontfix the bug.
>
> cheers,
>
> d
next prev parent reply other threads:[~2014-01-26 19:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 23:17 Bug: emacs 23.2 doesn't like ido-completing-read Mark Walters
2012-01-30 9:39 ` David Edmondson
2012-01-30 10:21 ` Mark Walters
2012-02-04 12:31 ` Mark Walters
2012-02-04 20:14 ` Tomi Ollila
2012-02-04 20:29 ` Mark Walters
2012-02-22 8:48 ` [PATCH] emacs: initialize ido mode in notmuch-mua.el Mark Walters
2014-01-25 18:34 ` David Bremner
2014-01-25 21:27 ` Tomi Ollila
2014-01-26 1:20 ` David Bremner
2014-01-26 11:09 ` Tomi Ollila
2014-01-26 13:28 ` David Bremner
2014-01-26 19:37 ` Mark Walters [this message]
2014-01-26 19:56 ` Tomi Ollila
2014-01-27 20:23 ` [PATCH 1/1] emacs: initialize ido(-completing-read) in emacs 23.[123] Tomi Ollila
2014-02-02 21:31 ` David Bremner
2014-02-03 20:29 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738kaa614.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).