From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2F05B431FBF for ; Wed, 16 Apr 2014 03:52:01 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a7hOnsWxKWJX for ; Wed, 16 Apr 2014 03:51:56 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 6F50B431FBD for ; Wed, 16 Apr 2014 03:51:56 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1WaNRX-0006tt-Eb; Wed, 16 Apr 2014 07:51:51 -0300 Received: (nullmailer pid 28687 invoked by uid 1000); Wed, 16 Apr 2014 10:51:47 -0000 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [WIP PATCH] emacs: hello: bugfix for saved searches defcustom In-Reply-To: <1397627927-9692-1-git-send-email-markwalters1009@gmail.com> References: <1397627927-9692-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.17+200~gd83a69b (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 16 Apr 2014 07:51:47 -0300 Message-ID: <8738hdwnr0.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2014 10:52:01 -0000 Mark Walters writes: > --- > Hi > > David found a bug in the recent notmuch hello saved searches and > reduced to a small test case. The problem occurs if the user sets > notmuch-saved-searches and then loads notmuch. The reason is that the > defcustom calls some utility functions and these need to be defined > (not just declared) when the defcustom is encountered. > > This patch moves the code around so that they are defined first. I > have marked the patch WIP as I am not sure what the best reordering > is, and we may want to rename some functions which have changed file > for namespace reasons. > > Anyway this fixes the test case. If it fixes the original bug too then > I will provide a better version. Hi Mark; This fixes the problem for me. Thanks for your efforts, d