unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [WIP PATCH] emacs: hello: bugfix for saved searches defcustom
Date: Wed, 16 Apr 2014 07:51:47 -0300	[thread overview]
Message-ID: <8738hdwnr0.fsf@zancas.localnet> (raw)
In-Reply-To: <1397627927-9692-1-git-send-email-markwalters1009@gmail.com>

Mark Walters <markwalters1009@gmail.com> writes:

> ---
> Hi
>
> David found a bug in the recent notmuch hello saved searches and
> reduced to a small test case. The problem occurs if the user sets
> notmuch-saved-searches and then loads notmuch. The reason is that the
> defcustom calls some utility functions and these need to be defined
> (not just declared) when the defcustom is encountered.
>
> This patch moves the code around so that they are defined first. I
> have marked the patch WIP as I am not sure what the best reordering
> is, and we may want to rename some functions which have changed file
> for namespace reasons.
>
> Anyway this fixes the test case. If it fixes the original bug too then
> I will provide a better version.

Hi Mark;

This fixes the problem for me.

Thanks for your efforts,

d

      reply	other threads:[~2014-04-16 10:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16  5:58 [WIP PATCH] emacs: hello: bugfix for saved searches defcustom Mark Walters
2014-04-16 10:51 ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738hdwnr0.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).