From: Mark Walters <markwalters1009@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, David Edmondson <dme@dme.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Correct the documentation for `notmuch-search-line-faces'.
Date: Tue, 06 May 2014 19:52:58 +0100 [thread overview]
Message-ID: <8738gmu4c5.fsf@qmul.ac.uk> (raw)
In-Reply-To: <m2siomhi4g.fsf@guru.guru-group.fi>
LGTM too +1
Mark
On Tue, 06 May 2014, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Tue, May 06 2014, David Edmondson <dme@dme.org> wrote:
>
>> The implementation and documentation for `notmuch-search-line-faces'
>> disagreed in how elements in the list were merged. Correct the
>> documentation to match the implementation (that is, the earlier
>> elements in the list have precedence over later elements).
>
> LGTM.
>
> Tomi
>
>
>
>> ---
>> emacs/notmuch.el | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
>> index 6c0bc1b..8aa0104 100644
>> --- a/emacs/notmuch.el
>> +++ b/emacs/notmuch.el
>> @@ -647,12 +647,12 @@ of the result."
>> Here is an example of how to color search results based on tags.
>> (the following text would be placed in your ~/.emacs file):
>>
>> - (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"
>> - :background \"blue\"))
>> - (\"unread\" . (:foreground \"green\"))))
>> + (setq notmuch-search-line-faces '((\"unread\" . (:foreground \"green\"))
>> + (\"deleted\" . (:foreground \"red\"
>> + :background \"blue\"))))
>>
>> -The attributes defined for matching tags are merged, with later
>> -attributes overriding earlier. A message having both \"deleted\"
>> +The attributes defined for matching tags are merged, with earlier
>> +attributes overriding later. A message having both \"deleted\"
>> and \"unread\" tags with the above settings would have a green
>> foreground and blue background."
>> :type '(alist :key-type (string) :value-type (custom-face-edit))
>> --
>> 2.0.0.rc0
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-05-06 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 11:14 precedence in `notmuch-search-line-faces' David Edmondson
2014-05-04 7:31 ` Mark Walters
2014-05-06 9:40 ` David Edmondson
2014-05-06 9:42 ` [PATCH] emacs: Correct the documentation for `notmuch-search-line-faces' David Edmondson
2014-05-06 10:03 ` David Edmondson
2014-05-06 10:09 ` David Edmondson
2014-05-06 18:33 ` Tomi Ollila
2014-05-06 18:52 ` Mark Walters [this message]
2014-05-17 21:47 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738gmu4c5.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).