From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 79808431FB6 for ; Sun, 18 Jan 2015 09:09:23 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 2.438 X-Spam-Level: ** X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sK+jR1FXQb6B for ; Sun, 18 Jan 2015 09:09:19 -0800 (PST) Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net [87.98.215.224]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4CECB431FAF for ; Sun, 18 Jan 2015 09:09:19 -0800 (PST) Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim 4.80) (envelope-from ) id 1YCtK0-0007pA-Dq; Sun, 18 Jan 2015 17:07:32 +0000 Received: (nullmailer pid 30087 invoked by uid 1000); Sun, 18 Jan 2015 17:07:19 -0000 From: David Bremner To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] crypto: refactor context creation to facilitate further work In-Reply-To: <760fe8048f9f3a641297a40ed129abc6695b6b94.1421577605.git.jani@nikula.org> References: <1421568167-18683-3-git-send-email-david@tethera.net> <760fe8048f9f3a641297a40ed129abc6695b6b94.1421577605.git.jani@nikula.org> User-Agent: Notmuch/0.19+27~g29ffde4 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Sun, 18 Jan 2015 18:07:19 +0100 Message-ID: <873878t3ug.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jan 2015 17:09:23 -0000 Jani Nikula writes: > --- > crypto.c | 27 +++++++++++++++++---------- > 1 file changed, 17 insertions(+), 10 deletions(-) No real objections. Although it's kindof implicit in "refactor", it might make sense to note in the commit message that it's just code movement. d