From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 97C9E6DE00DB for ; Fri, 3 Jun 2016 05:55:07 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.012 X-Spam-Level: X-Spam-Status: No, score=-0.012 tagged_above=-999 required=5 tests=[AWL=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RCqoBAeEX32t for ; Fri, 3 Jun 2016 05:54:59 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 8FA876DE02A6 for ; Fri, 3 Jun 2016 05:54:13 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84) (envelope-from ) id 1b8obu-0004BK-S1; Fri, 03 Jun 2016 08:53:58 -0400 Received: (nullmailer pid 4516 invoked by uid 1000); Fri, 03 Jun 2016 12:54:08 -0000 From: David Bremner To: Daniel Kahn Gillmor , notmuch@notmuchmail.org Subject: Re: [RFC2 Patch 5/5] lib: iterator API for message properties In-Reply-To: <87inxrqyv1.fsf@alice.fifthhorseman.net> References: <1463927339-5441-1-git-send-email-david@tethera.net> <1464608999-14774-1-git-send-email-david@tethera.net> <1464608999-14774-6-git-send-email-david@tethera.net> <8760tthfuy.fsf@zancas.localnet> <87pos1u14p.fsf@alice.fifthhorseman.net> <87eg8ht2sb.fsf@alice.fifthhorseman.net> <87lh2ofpxk.fsf@zancas.localnet> <87inxrqyv1.fsf@alice.fifthhorseman.net> User-Agent: Notmuch/0.22+28~gb9bf3f4 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 03 Jun 2016 09:54:00 -0300 Message-ID: <8737oufn6f.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 12:55:07 -0000 --=-=-= Content-Type: text/plain Daniel Kahn Gillmor writes: > > I think this makes sense, and makes me more comfortable with the overall > idea of this patch series. maybe it'd be useful to clearly document the > intended scope? > Sure, where do you think that kind of documentation is appropriate? There is the giant comment about the database schema in lib/database.cc. Actually I just noticed I already failed to update that for libconfig stuff. > > From elsewhere: > > * for messages which have multiple files, which file is actually indexed yes. Although rather than storing that, I think the right answer is more like "all of them". > * thread-id > * tag > > we're now talking about adding properties, which are in the "elsewhere" > category, right? Correct. > > It's worth noticing that the stuff in "elsewhere" is the stuff that > won't propagate across a dump/restore unless it's explicitly in the dump > somehow. We currently fail to restore thread-id and which file is > actually indexed across a dump/restore :/ The thread-id is in some sense derived from the message itself. Not in a reproducable way, but still, the dump file is the minimal set of extra data needed to reconstruct an equivalent database (pax threading bugs). > I think you've convinced me that it's good to go ahead with the > properties, assuming it's scoped as defined above. I still think that > we need a better story for upgrades to the dump format in general, but > maybe this isn't the place to make that particular case. > > --dkg I'm not sure what you have in mind, something more ambitious than the header added post 0.22? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQGcBAEBCAAGBQJXUX3pAAoJEPIClx2kp54sHwgL/3mH0iM4myE4hF6a7N4dgRJZ pHBSKknIlHU+5GJUc9gztdjKfTQZk/lUqPsW8ibh9hGzWyWvrsqZcSvlQr1tGnCD bx6K6qO4ES4hSDlysyiyCje/XKuFLGi9mD09DRxJjSL+Rlezy9SoLTiqG/JIhoB8 6Q6pF1etof4l/ysm99+9u5ITO9gW3cc4x6xQpLPjeNLkFrmFfG9RBT/bsDhe2jq7 Fyan4uXWCXICuTxnBP5uYrc1UMJPmaczxkEOPKCD9Af52o8sQIm74uYdUNYHuJIR 0R+xMlQJX415WhMrjvnnCNpuWDQOZHKF2R68Dp4QXbIzTK05uPcKoBGAI7BE25Y4 Vv1UefIyWp8s4KGbpLJRdbbu4eycqobT3WL9XwCtzrm58fyOu0g06YksKxrvjIN3 yZm4/SvzUaD9JlfJOjRxNGSxKErRBNEYTtOo0ZXT1BOy2tG6jltU6YlcGghEcTmX x+/p/C7nQS6bfy4jqvYmnDDSq/uD28sHbmUYRlxtaQ== =RGB8 -----END PGP SIGNATURE----- --=-=-=--