From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id F2B6F6DE0C64 for ; Fri, 11 Nov 2016 04:11:21 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.006 X-Spam-Level: X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5 tests=[AWL=0.005, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lp9X1heBM1on for ; Fri, 11 Nov 2016 04:11:20 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id AFE9B6DE0C51 for ; Fri, 11 Nov 2016 04:11:20 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1c5Afb-0003rw-D3; Fri, 11 Nov 2016 07:10:59 -0500 Received: (nullmailer pid 32219 invoked by uid 1000); Fri, 11 Nov 2016 12:11:17 -0000 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v2] emacs: add compatability functions for emacs 23 In-Reply-To: <1477736487-31319-1-git-send-email-markwalters1009@gmail.com> References: <1477736487-31319-1-git-send-email-markwalters1009@gmail.com> Date: Fri, 11 Nov 2016 08:11:17 -0400 Message-ID: <8737iy6wt6.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 12:11:22 -0000 Mark Walters writes: > Some of the recent changes to the emacs code have used functions > introduced in emacs 24. The functions used are read-char-choice and > setq-local. This changeset adds compatability functions to > notmuch-lib so that it should work on emacs 23. > --- > 1) please could someone with emacs 23 see if the testsuite passes? My > system with emacs 23 is so outdated the test suite doesn't run (wrong > python versions I think). I get many failures like emacsclient.emacs23: connect: Connection refused emacsclient.emacs23: error accessing socket "/tmp/emacs1000/notmuch-test-suite-21492" At a guess, somehow the server is shutting down/dying. I did manage to manually run an emacs server on this machine, and the socket is being created in the file system. > 2) Is the copyright notice I have included above the two functions > sufficient, and suitably placed? I think it would be best to modify the copyright at the top of the file. So to avoid confusing (if for some unforseen reason we wanted to relicense this file), it might be best to go with a seperate file. But lets see if someone can figure out the issue with the test suite before putting much more effort into it.