From: David Bremner <david@tethera.net>
To: Ioan-Adrian Ratiu <adi@adirat.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 11/11] emacs: notmuch-show: add filesize to headerline
Date: Sat, 10 Jun 2017 21:55:42 -0300 [thread overview]
Message-ID: <8737b7cpgx.fsf@tethera.net> (raw)
In-Reply-To: <20170518222708.30032-12-adi@adirat.com>
Ioan-Adrian Ratiu <adi@adirat.com> writes:
> date
> ") ("
> + (file-size-human-readable filesize)
> + ") ("
> (notmuch-tag-format-tags tags tags)
I think this should probably be optional. I don't know that everyone
will want to give up the screen space for this. I'm not sure how hard it
would be to have a fully customizable format like notmuch-search-result-format
Another thing I noticed is that your emacs code crashes when used
against an older version of notmuch. You can either make the emacs code
more robust, or use the format-version machinery to ensure that the
emacs binary version is new enough. The former is probably nicer since
you most likely want to gracefully handle databases without the filesize
value slot.
Finally, with the current patch series, there are over 200 failing
tests. That's obviously something to improve ;).
d
next prev parent reply other threads:[~2017-06-11 0:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 22:26 [PATCH v2 00/11] Add filesize index, search, sort & emacs UI Ioan-Adrian Ratiu
2017-05-18 22:26 ` [PATCH v2 01/11] lib: message: index message file sizes Ioan-Adrian Ratiu
2017-06-06 23:47 ` David Bremner
2017-06-08 11:39 ` David Bremner
2017-05-18 22:26 ` [PATCH v2 02/11] lib: database: store message filesize & add range processor Ioan-Adrian Ratiu
2017-06-09 23:18 ` David Bremner
2017-05-18 22:27 ` [PATCH v2 03/11] notmuch-search: add filesize based sort order Ioan-Adrian Ratiu
2017-05-19 9:42 ` Tomi Ollila
2017-05-22 13:37 ` Ioan-Adrian Ratiu
2017-06-10 0:30 ` David Bremner
2017-05-18 22:27 ` [PATCH v2 04/11] emacs: make notmuch-search-oldest-first generic Ioan-Adrian Ratiu
2017-06-11 0:13 ` David Bremner
2017-05-18 22:27 ` [PATCH v2 05/11] emacs: notmuch-search: add filesize sorting Ioan-Adrian Ratiu
2017-06-11 0:15 ` David Bremner
2017-05-18 22:27 ` [PATCH v2 06/11] sprinter: add unsigned_long printer function Ioan-Adrian Ratiu
2017-05-23 16:53 ` Jani Nikula
2017-05-18 22:27 ` [PATCH v2 07/11] lib: thread: add thread total size function Ioan-Adrian Ratiu
2017-06-11 0:16 ` David Bremner
2017-05-18 22:27 ` [PATCH v2 08/11] notmuch-search: output total_filesize thread result Ioan-Adrian Ratiu
2017-06-11 0:22 ` David Bremner
2017-05-18 22:27 ` [PATCH v2 09/11] notmuch-show: export message filesize Ioan-Adrian Ratiu
2017-06-11 0:42 ` David Bremner
2017-05-18 22:27 ` [PATCH v2 10/11] emacs: notmuch-search: add display thread sizes capability Ioan-Adrian Ratiu
2017-06-11 0:24 ` David Bremner
2017-06-11 0:40 ` David Bremner
2017-05-18 22:27 ` [PATCH v2 11/11] emacs: notmuch-show: add filesize to headerline Ioan-Adrian Ratiu
2017-06-11 0:55 ` David Bremner [this message]
2017-05-23 17:19 ` [PATCH v2 00/11] Add filesize index, search, sort & emacs UI Jani Nikula
2017-05-23 19:20 ` Ioan-Adrian Ratiu
2017-06-06 18:51 ` David Bremner
2017-06-06 23:11 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737b7cpgx.fsf@tethera.net \
--to=david@tethera.net \
--cc=adi@adirat.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).