unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v2] configure: Ensure that GMime can extract session keys
Date: Mon, 20 May 2019 16:46:23 -0300	[thread overview]
Message-ID: <8736l86h9s.fsf@tethera.net> (raw)
In-Reply-To: <20190506201655.16276-1-dkg@fifthhorseman.net>

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> GMime 3.0 and higher can extract session keys, but it will *not*
> extract session keys if it was built with --disable-crypto, or if it
> was built against GPGME version < 1.8.0.
>
> Notmuch currently expects to be able to extract session keys, and
> tests will fail if it is not possible, so we ensure that this is the
> case during ./configure time.
>
> Part of this feels awkward because notmuch doesn't directly depend on
> gpg at all.  Rather, it depends on GMime, and the current
> implementation of GMime depends on GPGME for its crypto, and GPGME in
> turn depends on gpg.
>
> So the use of gpg in ./configure isn't actually introducing a new
> dependency, though if a future version of GMime were ever to move away
> from GnuPG, we might need to reconsider.
>
> Note that this changeset depends on
> id:20190506174327.13457-1-dkg@fifthhorseman.net , which supplies the
> rfc822 message test/corpora/crypto/basic-encrypted.eml used in it.
>

I pushed this, and broke travis. Can you please have a look at

  https://travis-ci.org/notmuch/notmuch/builds/534979532

d

  parent reply	other threads:[~2019-05-20 19:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06 19:48 [PATCH] configure: Ensure that GMime can extract session keys Daniel Kahn Gillmor
2019-05-06 20:16 ` [PATCH v2] " Daniel Kahn Gillmor
2019-05-06 20:19   ` Daniel Kahn Gillmor
2019-05-20  3:13   ` Daniel Kahn Gillmor
2019-05-20 19:46   ` David Bremner [this message]
2019-05-20 21:00     ` Daniel Kahn Gillmor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736l86h9s.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=dkg@fifthhorseman.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).