From: Ralph Seichter <abbot@monksofcool.net>
To: notmuch@notmuchmail.org
Subject: Indentation style (was: [PATCH] notmuch-dump.c: Fix output file being closed twice)
Date: Sun, 28 Jul 2019 15:33:28 +0200 [thread overview]
Message-ID: <8736iqs2qf.fsf@ra.horus-it.com> (raw)
* David Bremner:
> I did have to revert one unrelated whitespace change.
I knew I might run afoul of that the minute I read "Indent is 4 spaces
with mixed tab/spaces and a tab width of 8" in the code style notes. ;-)
In my experience, it is error-prone to mix tabs and spaces. Perhaps it
would be useful to change to all spaces? Also, with an added editor mode
line, supporting that style would be more convenient (for Emacs and Vim
at least).
-Ralph
next reply other threads:[~2019-07-28 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 13:33 Ralph Seichter [this message]
2019-07-28 20:36 ` Indentation style (was: [PATCH] notmuch-dump.c: Fix output file being closed twice) David Bremner
2019-07-28 22:19 ` Indentation style Thomas Schneider
2019-07-29 0:56 ` Daniel Kahn Gillmor
2019-07-29 14:52 ` David Bremner
2019-07-29 21:23 ` Tomi Ollila
2019-07-30 13:09 ` Daniel Kahn Gillmor
2019-07-30 13:37 ` Ralph Seichter
2019-07-31 10:58 ` Tomi Ollila
2019-07-29 1:13 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736iqs2qf.fsf@ra.horus-it.com \
--to=abbot@monksofcool.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).