From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/5] tests: run python-cffi tests
Date: Thu, 21 Nov 2019 23:03:06 -0400 [thread overview]
Message-ID: <8736eg8vf9.fsf@tethera.net> (raw)
In-Reply-To: <m2bltk1zjq.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Fri, Nov 08 2019, David Bremner wrote:
>
>> Tomi Ollila <tomi.ollila@iki.fi> writes:
>>
>>>
>>> Right -- just that pytest-3 may not be available -- to iterate (tested)...
>>>
>>> if ${NOTMUCH_PYTHON} -m pytest -c $conf --version >/dev/null 2>&1; then
>>>
>>
>> The problem with this is that it might pass if pytest is only installed
>> for python2.
>
> What is the minimum python3 version supported -- In the previous email thread all
> references show python 3.7....
>
> Anyway, in that wip/cffi "branch" commit 97caf16c15d (check for python cffi module)
>
> could also include check for minimum python version, e.g.
>
> +printf "Checking for python 3 cffi... "
> +if "${NOTMUCH_PYTHON}" -c 'import sys,cffi; assert sys.version_info >= (3,7)' 2>/dev/null; then
> + printf "Yes.\n"
> + have_python3_cffi=1
> +else
> + printf "No.\n"
> + have_python3_cffi=0
> +fi
I (force) pushed an updated version of wip/cffi (8d1f30cb) with several changes
along those lines to the configure / build / test scaffolding. In
particular running the tests from the notmuch suite doesn't require
pytest-cov anymore, and pytest and cffi are both checked for only if
python3 is found.
d
next prev parent reply other threads:[~2019-11-22 3:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 1:39 python CFFI bindings integration into notmuch build/test David Bremner
2019-11-04 1:39 ` [PATCH 1/5] bindings/python-cffi: preserve environment for tests David Bremner
2019-11-04 1:39 ` [PATCH 2/5] configure: check for python cffi module David Bremner
2019-11-04 21:24 ` Tomi Ollila
2019-11-04 1:39 ` [PATCH 3/5] build: optionally build python-cffi bindings David Bremner
2019-11-04 21:26 ` Tomi Ollila
2019-11-05 0:32 ` David Bremner
2020-05-22 1:06 ` Daniel Kahn Gillmor
2019-11-04 1:39 ` [PATCH 4/5] tests: run python-cffi tests David Bremner
2019-11-04 16:18 ` Tomi Ollila
2019-11-04 16:57 ` David Bremner
2019-11-04 21:45 ` Tomi Ollila
2019-11-04 22:04 ` Tomi Ollila
2019-11-06 2:19 ` David Bremner
2019-11-06 20:51 ` Tomi Ollila
2019-11-09 1:36 ` David Bremner
2019-11-09 21:59 ` Tomi Ollila
2019-11-22 3:03 ` David Bremner [this message]
2019-11-26 0:52 ` David Bremner
2019-12-03 12:16 ` David Bremner
2019-11-04 1:39 ` [PATCH 5/5] travis: add python3-{cffi,pytest,setuptools} David Bremner
2019-11-04 11:10 ` python CFFI bindings integration into notmuch build/test David Bremner
2019-11-05 20:47 ` Tomi Ollila
2019-11-06 2:22 ` David Bremner
2019-11-14 18:52 ` Floris Bruynooghe
2019-11-14 20:20 ` Tomi Ollila
2019-11-14 22:24 ` Floris Bruynooghe
2019-11-14 23:09 ` Floris Bruynooghe
2019-11-16 15:51 ` David Bremner
2019-11-17 14:40 ` Floris Bruynooghe
2019-11-17 16:09 ` David Bremner
2019-11-16 15:43 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736eg8vf9.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).