From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 517036DE0EB8 for ; Wed, 27 Nov 2019 11:01:32 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -1.018 X-Spam-Level: X-Spam-Status: No, score=-1.018 tagged_above=-999 required=5 tests=[AWL=-0.466, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TevdZXWLK7vg for ; Wed, 27 Nov 2019 11:01:27 -0800 (PST) Received: from mail.kapsi.fi (mail.kapsi.fi [91.232.154.25]) by arlo.cworth.org (Postfix) with ESMTPS id A66D56DE0EB0 for ; Wed, 27 Nov 2019 11:01:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gcMMj1WdIE2g5RXRT3ZemI9GXAoX1t9xu8Oc7ekOWBo=; b=Bwb0L+KKW8JHR1vdiFjMVGdF2m iUOZeFliZbupCNh7Zyv8vq+Kcbbe0j3bGMBdWY1OMkqa89yqcL7BKCypLuesmeeqXBiCXTMNYU105 f4KCrLoPudSo7q8ZQnJRAARUunTz8EYACG7hNJ2RmEWTNE3nOdlll2ns1BPAqQ2Jgpe47VrUgI4nZ Bdkm3gRHw8aGWXN+USYmkY89Kirgk4/DfdHZlxoeQuVuXlOSPNwnal/GjJ3V86YCc9MccHI2UWbPf wd/8kX4dU0prrBuhX6o1vbE+w3rtgYDs92iExAa06k9Whm7uK7E/wpLMuFJfJZGMRl5w3voDlWCR9 OyCz9IOg==; Received: from mobile-access-6df079-167.dhcp.inet.fi ([109.240.121.167] helo=mithlond) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ia2Yz-0007jQ-Np; Wed, 27 Nov 2019 21:01:21 +0200 From: Teemu Likonen To: William Casarin , notmuch@notmuchmail.org Subject: Re: [PATCH 0/7] Port notmuch-show's x/X bindings to notmuch-tree In-Reply-To: <87a78r0xz0.fsf@iki.fi> References: <20191117222929.1064-1-jb55@jb55.com> <87a78r0xz0.fsf@iki.fi> Date: Wed, 27 Nov 2019 21:01:14 +0200 Message-ID: <8736e9kuth.fsf@iki.fi> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-SA-Exim-Connect-IP: 109.240.121.167 X-SA-Exim-Mail-From: tlikonen@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Nov 2019 19:01:32 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Teemu Likonen [2019-11-20T10:10:43+02] wrote: > William Casarin [2019-11-17T14:29:22-08] wrote: >> These patches bring notmuch-tree more in line with the user experience >> of notmuch-show by adding the x/X bindings. > > I have not tested the patch set yet but I think it is very good idea > to add x/X keybindings to make tree view work similarly to show view. Now I have been using the patch set some days and it works as expected. Usually I open a thread with M-TAB (notmuch-tree-from-search-thread) and if I then find thread uninteresting I hit "X" (notmuch-tree-archive-thread-then-exit) and continue browsing the thread list. I'm quite experienced with Emacs Lisp (and Common Lisp) but I don't know Notmuch Emacs code to give educated comments on this patch set's code. From=20user's side it works and I support this feature. Thanks! =2D-=20 /// OpenPGP key: 4E1055DC84E9DFF613D78557719D69D324539450 // https://keys.openpgp.org/search?q=3Dtlikonen@iki.fi / https://keybase.io/tlikonen https://github.com/tlikonen --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFEBAEBCgAuFiEEkhZiiC54Bnj5a16Skzo1BB5+rVEFAl3ex/oQHHRsaWtvbmVu QGlraS5maQAKCRCTOjUEHn6tUfRzB/9PrRBnbqc2URJJHpkXVmJmOLaClYjmvRGs jqwtKPuTy3MbQIOacPRjTVD+v3cQEfrDKQXjvjdclXYlEbQBHeyu9aBykzJptgz6 b5cYNSyLR5wnPRLemWWf67hJm1wwlQdglWykqU50se9IV+rViN0FDDIoVpfQv6Jk msPnlqeWzF2tthrn3ySkB6Wow6UtDHAA9SBeI8Ykm1Mn/ZKBwkGCHduOsEoS3UCk tOBgbtZ4ZOdrniyd/pojuwjkve97zwwLiQuqipguHD3vmcULZvyZxunC+o/sYwvQ 5T6/maSoSfOErZP8ysz9VqMIwnIMIW+/M+L9EVawOTMEDcjEeKd5iIYEARYIAC4W IQTJW2wqtelxC1gHdbitnXWr7pTCcwUCXd7IABAcdGxpa29uZW5AaWtpLmZpAAoJ EK2ddavulMJzmuUBAOqhLo5yRNqUXXeWHyTDNfR6Q20iHT9ZXKNTWUM+asHIAQCd h4uG8nEw9FQ7A9/nL1ivKpFg3qu3IK5W5Wn3Oe1vCA== =L01H -----END PGP SIGNATURE----- --=-=-=--