From: Teemu Likonen <tlikonen@iki.fi>
To: William Casarin <jb55@jb55.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/7] Port notmuch-show's x/X bindings to notmuch-tree
Date: Wed, 27 Nov 2019 21:01:14 +0200 [thread overview]
Message-ID: <8736e9kuth.fsf@iki.fi> (raw)
In-Reply-To: <87a78r0xz0.fsf@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
Teemu Likonen [2019-11-20T10:10:43+02] wrote:
> William Casarin [2019-11-17T14:29:22-08] wrote:
>> These patches bring notmuch-tree more in line with the user experience
>> of notmuch-show by adding the x/X bindings.
>
> I have not tested the patch set yet but I think it is very good idea
> to add x/X keybindings to make tree view work similarly to show view.
Now I have been using the patch set some days and it works as expected.
Usually I open a thread with M-TAB (notmuch-tree-from-search-thread) and
if I then find thread uninteresting I hit "X"
(notmuch-tree-archive-thread-then-exit) and continue browsing the thread
list.
I'm quite experienced with Emacs Lisp (and Common Lisp) but I don't know
Notmuch Emacs code to give educated comments on this patch set's code.
From user's side it works and I support this feature. Thanks!
--
/// OpenPGP key: 4E1055DC84E9DFF613D78557719D69D324539450
// https://keys.openpgp.org/search?q=tlikonen@iki.fi
/ https://keybase.io/tlikonen https://github.com/tlikonen
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 694 bytes --]
prev parent reply other threads:[~2019-11-27 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 22:29 [PATCH 0/7] Port notmuch-show's x/X bindings to notmuch-tree William Casarin
2019-11-17 22:29 ` [PATCH 1/7] emacs/tree: return true if a thread was found in next-thread William Casarin
2019-11-17 22:29 ` [PATCH 2/7] emacs/tree: add notmuch-tree-goto-matching-message William Casarin
2019-11-17 22:29 ` [PATCH 3/7] emacs/tree: add notmuch-tree-matching-message William Casarin
2019-11-17 22:29 ` [PATCH 4/7] emacs/tree: add kill-both prefix argument to notmuch-tree-quit William Casarin
2019-11-17 22:29 ` [PATCH 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit William Casarin
2019-11-17 23:17 ` William Casarin
2019-11-18 14:49 ` David Edmondson
2019-11-18 15:21 ` William Casarin
2019-11-17 22:29 ` [PATCH 6/7] emacs/tree: add notmuch-tree-archive-thread-then-exit William Casarin
2019-11-17 22:29 ` [PATCH 7/7] emacs/tree: add x/X bindings William Casarin
2019-11-20 8:10 ` [PATCH 0/7] Port notmuch-show's x/X bindings to notmuch-tree Teemu Likonen
2019-11-27 19:01 ` Teemu Likonen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736e9kuth.fsf@iki.fi \
--to=tlikonen@iki.fi \
--cc=jb55@jb55.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).