From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cE0YOeT8xl6pOQAA0tVLHw (envelope-from ) for ; Thu, 21 May 2020 22:12:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cDL2NOT8xl51WQAAbx9fmQ (envelope-from ) for ; Thu, 21 May 2020 22:12:52 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 792E89400EF for ; Thu, 21 May 2020 22:12:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 859966DE0F54; Thu, 21 May 2020 15:12:48 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AKbZSqcpJ_Ub; Thu, 21 May 2020 15:12:48 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 5D4906DE0F5C; Thu, 21 May 2020 15:12:47 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 077CB6DE0F5C for ; Thu, 21 May 2020 15:12:46 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pQfY-I3VBjed for ; Thu, 21 May 2020 15:12:45 -0700 (PDT) Received: from che.mayfirst.org (unknown [162.247.75.117]) by arlo.cworth.org (Postfix) with ESMTPS id 5B6726DE0F54 for ; Thu, 21 May 2020 15:12:45 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1590099162; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=SqBRY1N34aYLvAd9bMZ4hpuRnE5nNPYRsCZ1UN/sbrM=; b=tvsjayjQDZzmzdfSljQ1Oq6QawKSoyGqYoLfDf+hS84PjDLL0Qe7YR/+yA4Zh38CQlAk9 mlDftnVAfAfmTQrBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1590099162; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=SqBRY1N34aYLvAd9bMZ4hpuRnE5nNPYRsCZ1UN/sbrM=; b=aYEiF9rCDu5xj94bcP2OKohp6dNW30nNRSsfXMEb6z9ji8EUTNn41iutwRjTaXKMEKFd9 KN7pyS0ZlhXw1RB6X9SrgnTKLF4MTKrMCevGLCpn2mOgplkWlsE1o1uk0PlS/SGPMic/fbM MG4U/tER7NCSZK2mTCmqKJE7eY7Z3Sf9RB2x9QEUOQ7C4wJ+RSRwIuLkFrx+ui7V5gUA23v VKfbHkl4KTRO8eBNKnY4oBMBZbU77l/SoMGWe7hmQ3M77cwxOnpqykJ9tT2xcf3Ly/uy7eY g7TbJC/Dn1riYWCL4wQFitzg42R7nRXB79g+8wWwqZC2xzqX0De1smoEDFag== Received: from fifthhorseman.net (unknown [IPv6:2001:470:1f07:60d:f2de:f1ff:fec3:d109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 75C4DF9A5; Thu, 21 May 2020 18:12:42 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id A86F120120; Thu, 21 May 2020 17:56:47 -0400 (EDT) From: Daniel Kahn Gillmor To: Radu Butoi , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: split-window-sensibly in tree mode with open message In-Reply-To: References: Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQULCQgH AgYVCgkICwIEFgIDAQIeAQIXgAIZARYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJd5Hw3BQkFpJWB AAoJEPIGkReQOOXGDYEA/j0ERjPxDleKMZ2LDcWc/3o5cLFwAVzBKQHppu0Be5IWAP0aeTnyEqlp RTE7M8zugwkhYeUYfYu0BjecDUMnYz6iDLgzBF3kewUWCSsGAQQB2kcPAQEHQK1IuW0GZmcrs2mx CYMl8IHse0tMF8cP7eBNXevrlx2ZiPUEGBYIACYCGwIWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUC XeR7TwUJAiGl/gCBdiAEGRYIAB0WIQQsv6x2UaqQJzY+dXHEDyVUMvKBDwUCXeR7BQAKCRDEDyVU MvKBD7KmAQCHs+7588C4jto6fMje0Nu97zzoppjJM7lrGF2rVnbHvwD+MgmGUbHzPSUrTWnZBQDi /QM595bxNrBA4N1CiXhs2AMJEPIGkReQOOXGpp0BAM7YeBnt/UNvxJAGm4DidSfHU7RDMWe6Tgux HrH21cDkAQC9leNFXJsQ7F2ZniRPHa8CkictcQEKPL8VCWpfe8LbArg4BF3ke5wSCisGAQQBl1UB BQEBB0Cf+EiAXtntQMf51xpqb6uZ5O0eCLAZtkg0SXHjA1JlEwMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJd5HucAhsMBQkCIaVkAAoJEPIGkReQOOXGdYcBANYnW7VyL2CncKH1 iO4Zr0IwfdIv6rai1PUHL98pVi3cAP9tMh85CKGDa0Xi/fptQH41meollLW5tLb/bEWMuUNuBQ== Date: Thu, 21 May 2020 17:56:46 -0400 Message-ID: <87367tj6jl.fsf@fifthhorseman.net> MIME-Version: 1.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4805191227252658490==" Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=fifthhorseman.net header.s=2019 header.b=tvsjayjQ; dkim=fail (body hash did not verify) header.d=fifthhorseman.net header.s=2019rsa header.b=aYEiF9rC; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fifthhorseman.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -0.51 X-TUID: u8mMjvJS22+b --===============4805191227252658490== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain On Sat 2020-05-02 20:11:09 -0400, Radu Butoi wrote: > This uses the standard Emacs function `split-window-sensibly` to split a > window horizontally or vertically depending on space when opening a > message in tree view. By default, split-width-threshold is 160 columns > (and -height- is nil), so screens wider than 160 will be split > horizontally. > > This is based on an older proposal [1] which manually did the > calculation of width. The main issues there were (1) lack of > configurability and (2) lack of testing. I don't have an answer for > testing, but this allows users to configure two thresholds using > built-in variables, an improvement. I like this proposal, and the simplification that it gives to the notmuch-emacs codebase. However, this thread is the first place i've learned about split-window-sensibly, so i'm probably not eligible to really judge the merits here. As far as testing goes, a test would be nice -- is this something you could add to test/T460-emacs-tree.sh ? Testing UI/UX issues is always pretty tough though, and it's not clear to me that we're actually already testing the existing "(/ (window-height) 4)" business anyway. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQsv6x2UaqQJzY+dXHEDyVUMvKBDwUCXsb5HwAKCRDEDyVUMvKB D69gAP9/o2p3ALFmwZLx5QYwmHN64nQ+2lCuyqekH6SDjqJrVQD/Qu/YKUrMW6O2 i4ShLLLSCxzz5/XPXM+dCB1WlI1SwgU= =T+2Q -----END PGP SIGNATURE----- --=-=-=-- --===============4805191227252658490== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============4805191227252658490==--