unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] tests: fix test_json_nodes() in out-of-tree builds
Date: Tue, 26 May 2020 10:36:55 -0400	[thread overview]
Message-ID: <87367miwzc.fsf@fifthhorseman.net> (raw)
In-Reply-To: <m2zh9xb4e6.fsf@guru.guru-group.fi>


[-- Attachment #1.1: Type: text/plain, Size: 799 bytes --]

On Sun 2020-05-24 20:59:29 +0300, Tomi Ollila wrote:
> On Thu, May 21 2020, Daniel Kahn Gillmor wrote:
>
>> In out-of-tree builds, $TEST_DIRECTORY doesn't contain
>> json_check_nodes.py.  This caused 27 tests to fail in such an
>> environment.
>
> are you shure the run_emacs.sh change in 
>
> id:"20200423212643.864-1-tomi.ollila@iki.fi"
>
> is not needed ? =D

Sorry, i'd missed that message entirely.  Looks like we were barking up
the same tree :)

I do not mean to cast doubt on the run_emacs.sh change -- i haven't seen
the particular failure with two different versions of emacs, so i don't
know that i can comment on it.

At any rate, these seem like two distinct fixes.  I'd be happy to see
them both applied, so maybe just drop my patch and merge Tomi's?

   --dkg

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



      reply	other threads:[~2020-05-26 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  1:16 [PATCH] tests: fix test_json_nodes() in out-of-tree builds Daniel Kahn Gillmor
2020-05-24 17:59 ` Tomi Ollila
2020-05-26 14:36   ` Daniel Kahn Gillmor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87367miwzc.fsf@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).