unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / Atom feed
* [PATCH] devel/release-checks.sh: use grep to find copyright year.
@ 2020-08-16 14:36 David Bremner
  2020-08-16 15:36 ` Tomi Ollila
  0 siblings, 1 reply; 3+ messages in thread
From: David Bremner @ 2020-08-16 14:36 UTC (permalink / raw)
  To: notmuch; +Cc: David Bremner

This is quite fragile, but it works for now, unlike the python
version.

In general it seems conf.py is not intended to be evaluated outside of
sphinx, as it assumes certain global names (in particular "tags") are
defined.
---

 I am going to apply this to unblock the release process, but I
 welcome better solutions.
 
 devel/release-checks.sh | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/devel/release-checks.sh b/devel/release-checks.sh
index 7ba94822..cfa208d5 100755
--- a/devel/release-checks.sh
+++ b/devel/release-checks.sh
@@ -178,10 +178,7 @@ esac
 year=`exec date +%Y`
 echo -n "Checking that copyright in documentation contains 2009-$year... "
 # Read the value of variable `copyright' defined in 'doc/conf.py'.
-# As __file__ is not defined when python command is given from command line,
-# it is defined before contents of 'doc/conf.py' (which dereferences __file__)
-# is executed.
-copyrightline=`exec python -c "with open('doc/conf.py') as cf: __file__ = ''; exec(cf.read()); print(copyright)"`
+copyrightline=$(grep ^copyright doc/conf.py)
 case $copyrightline in
 	*2009-$year*)
 		echo Yes. ;;
-- 
2.28.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] devel/release-checks.sh: use grep to find copyright year.
  2020-08-16 14:36 [PATCH] devel/release-checks.sh: use grep to find copyright year David Bremner
@ 2020-08-16 15:36 ` Tomi Ollila
  2020-08-17 23:58   ` David Bremner
  0 siblings, 1 reply; 3+ messages in thread
From: Tomi Ollila @ 2020-08-16 15:36 UTC (permalink / raw)
  To: David Bremner, notmuch

On Sun, Aug 16 2020, David Bremner wrote:

> This is quite fragile, but it works for now, unlike the python
> version.
>
> In general it seems conf.py is not intended to be evaluated outside of
> sphinx, as it assumes certain global names (in particular "tags") are
> defined.
> ---
>
>  I am going to apply this to unblock the release process, but I
>  welcome better solutions.

for this case solution is good enough...

>  
>  devel/release-checks.sh | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/devel/release-checks.sh b/devel/release-checks.sh
> index 7ba94822..cfa208d5 100755
> --- a/devel/release-checks.sh
> +++ b/devel/release-checks.sh
> @@ -178,10 +178,7 @@ esac
>  year=`exec date +%Y`
>  echo -n "Checking that copyright in documentation contains 2009-$year... "
>  # Read the value of variable `copyright' defined in 'doc/conf.py'.
> -# As __file__ is not defined when python command is given from command line,
> -# it is defined before contents of 'doc/conf.py' (which dereferences __file__)
> -# is executed.
> -copyrightline=`exec python -c "with open('doc/conf.py') as cf: __file__ = ''; exec(cf.read()); print(copyright)"`
> +copyrightline=$(grep ^copyright doc/conf.py)

For consistency and to save one fork(2) $(exec grep ...), but I could
live with this, too ;D

So LGTM.

Tomi

(2) bash forks for subshell and then for grep, even in this trivial case.
Other shells fork only once.

>  case $copyrightline in
>  	*2009-$year*)
>  		echo Yes. ;;
> -- 
> 2.28.0
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] devel/release-checks.sh: use grep to find copyright year.
  2020-08-16 15:36 ` Tomi Ollila
@ 2020-08-17 23:58   ` David Bremner
  0 siblings, 0 replies; 3+ messages in thread
From: David Bremner @ 2020-08-17 23:58 UTC (permalink / raw)
  To: Tomi Ollila, notmuch

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Sun, Aug 16 2020, David Bremner wrote:
>
>
> For consistency and to save one fork(2) $(exec grep ...), but I could
> live with this, too ;D
>
> So LGTM.

I guess I was a bit impatient. We can add the exec in the next cleanup
pass of configure I guess.

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-17 23:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-16 14:36 [PATCH] devel/release-checks.sh: use grep to find copyright year David Bremner
2020-08-16 15:36 ` Tomi Ollila
2020-08-17 23:58   ` David Bremner

unofficial mirror of notmuch@notmuchmail.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/notmuch/0 notmuch/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 notmuch notmuch/ https://yhetil.org/notmuch \
		notmuch@notmuchmail.org
	public-inbox-index notmuch

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.notmuch.general
	nntp://news.gmane.io/gmane.mail.notmuch.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git