From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id J1KHBmmdQl9HQAAA0tVLHw (envelope-from ) for ; Sun, 23 Aug 2020 16:46:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4JXOAWmdQl/GNwAAbx9fmQ (envelope-from ) for ; Sun, 23 Aug 2020 16:46:33 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6434A9404CE for ; Sun, 23 Aug 2020 16:46:32 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 4F31129BF8; Sun, 23 Aug 2020 12:46:26 -0400 (EDT) Received: from jb55.com (unknown [IPv6:2600:3c01::f03c:91ff:fe08:5bfb]) by mail.notmuchmail.org (Postfix) with ESMTPS id A8AFD1FA17 for ; Sun, 23 Aug 2020 12:46:23 -0400 (EDT) Received: from jb55.com (S010660e327dca171.vc.shawcable.net [24.84.152.187]) by jb55.com (OpenSMTPD) with ESMTPSA id 77f82c93 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 23 Aug 2020 16:46:52 +0000 (UTC) From: William Casarin To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 2/5] NEWS: mention exception handling changes In-Reply-To: <20200823122502.273793-2-david@tethera.net> References: <20200823122502.273793-1-david@tethera.net> <20200823122502.273793-2-david@tethera.net> Date: Sun, 23 Aug 2020 09:46:19 -0700 Message-ID: <87364dfgys.fsf@jb55.com> MIME-Version: 1.0 Message-ID-Hash: GZCCDQQFGHL7QT7PBFR5BCHGCJ56KQ4V X-Message-ID-Hash: GZCCDQQFGHL7QT7PBFR5BCHGCJ56KQ4V X-MailFrom: jb55@jb55.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 1.83 X-TUID: VOQNFOTZ06GO David Bremner writes: > --- > NEWS | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/NEWS b/NEWS > index c1f09b18..e6392e81 100644 > --- a/NEWS > +++ b/NEWS > @@ -16,6 +16,14 @@ files to a maildir for mutt to access is replaced with internal perl > processing. This search operation is now more portable, and somewhat > faster. > > +Library > +------- > + > +Many small changes to exception handling in the library; this should > +largely eliminate terminations inside the library due to uncaught > +exceptions or internal errors. No doubt there are a few uncovered > +code paths still; please report them as bugs. subjective nit: Many small changes to exception handling in the library. This should largely eliminate terminations due to uncaught exceptions or internal errors. No doubt there are a few uncovered code paths still; please report them as bugs. Otherwise series LGTM