From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WO2DDvzmsl8JEQAA0tVLHw (envelope-from ) for ; Mon, 16 Nov 2020 20:54:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yIYzCvzmsl/wBQAAbx9fmQ (envelope-from ) for ; Mon, 16 Nov 2020 20:54:20 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 583B994021E for ; Mon, 16 Nov 2020 20:54:19 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5F81728824; Mon, 16 Nov 2020 15:54:12 -0500 (EST) Received: from mail.hostpark.net (mail.hostpark.net [212.243.197.30]) by mail.notmuchmail.org (Postfix) with ESMTPS id 1CC6120088 for ; Mon, 16 Nov 2020 15:54:09 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 1E956160EA; Mon, 16 Nov 2020 21:54:09 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id Q9y_gO7hd1GW; Mon, 16 Nov 2020 21:54:08 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id DB75D160AE; Mon, 16 Nov 2020 21:54:08 +0100 (CET) From: Jonas Bernoulli To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 13/27] emacs: place complete first sentence on first doc-string line In-Reply-To: References: <20201108190311.1397-1-jonas@bernoul.li> <20201108190311.1397-14-jonas@bernoul.li> Date: Mon, 16 Nov 2020 21:54:08 +0100 Message-ID: <8736192fbj.fsf@bernoul.li> MIME-Version: 1.0 Message-ID-Hash: CG2EMKROPCXFUKKXQYIFNR5OT24BXMR6 X-Message-ID-Hash: CG2EMKROPCXFUKKXQYIFNR5OT24BXMR6 X-MailFrom: jonas@bernoul.li X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -1.01 X-TUID: 59SNc+ZkuNN7 David Edmondson writes: > On Sunday, 2020-11-08 at 20:02:57 +01, Jonas Bernoulli wrote: > > With a suggested rewording below... > > Reviewed-by: David Edmondson > >> --- >> emacs/notmuch-crypto.el | 3 +-- >> emacs/notmuch-hello.el | 3 +-- >> emacs/notmuch-mua.el | 11 ++++------- >> 3 files changed, 6 insertions(+), 11 deletions(-) >> >> diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el >> index 276c9859..4fab215a 100644 >> --- a/emacs/notmuch-crypto.el >> +++ b/emacs/notmuch-crypto.el >> @@ -103,8 +103,7 @@ (define-button-type 'notmuch-crypto-status-button-type >> :supertype 'notmuch-button-type) >> >> (defun notmuch-crypto-insert-sigstatus-button (sigstatus from) >> - "Insert a button describing the signature status SIGSTATUS sent >> -by user FROM." >> + "Insert a button describing the signature status SIGSTATUS sent by user FROM." >> (let* ((status (plist-get sigstatus :status)) >> (show-button t) >> (face 'notmuch-crypto-signature-unknown) >> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el >> index 003bec33..28784345 100644 >> --- a/emacs/notmuch-hello.el >> +++ b/emacs/notmuch-hello.el >> @@ -372,8 +372,7 @@ (defvar notmuch-hello-hidden-sections nil >> "List of sections titles whose contents are hidden.") >> >> (defvar notmuch-hello-first-run t >> - "True if `notmuch-hello' is run for the first time, set to nil >> -afterwards.") >> + "True if `notmuch-hello' is run for the first time, set to nil afterwards.") >> >> (defun notmuch-hello-nice-number (n) >> (let (result) >> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el >> index 9d08c2c9..62d615d1 100644 >> --- a/emacs/notmuch-mua.el >> +++ b/emacs/notmuch-mua.el >> @@ -73,8 +73,7 @@ (defcustom notmuch-mua-user-agent-function nil >> :group 'notmuch-send) >> >> (defcustom notmuch-mua-hidden-headers nil >> - "Headers that are added to the `message-mode' hidden headers >> -list." >> + "Headers that are added to the `message-mode' hidden headers list." >> :type '(repeat string) >> :group 'notmuch-send) >> >> @@ -167,8 +166,7 @@ (defun notmuch-mua-get-switch-function () >> (t (error "Invalid value for `notmuch-mua-compose-in'")))) >> >> (defun notmuch-mua-maybe-set-window-dedicated () >> - "Set the selected window as dedicated according to >> -`notmuch-mua-compose-in'." >> + "Set the selected window as dedicated according to `notmuch-mua-compose-in'." >> (when (or (eq notmuch-mua-compose-in 'new-frame) >> (eq notmuch-mua-compose-in 'new-window)) >> (set-window-dedicated-p (selected-window) t))) >> @@ -335,9 +333,8 @@ (define-derived-mode notmuch-message-mode message-mode "Message[Notmuch]" >> (put 'notmuch-message-mode 'flyspell-mode-predicate 'mail-mode-flyspell-verify) >> >> (defun notmuch-mua-pop-to-buffer (name switch-function) >> - "Pop to buffer NAME, and warn if it already exists and is >> -modified. This function is notmuch adaptation of >> -`message-pop-to-buffer'." >> + "Pop to buffer NAME, and warn if it already exists and is modified. >> +This function is notmuch adaptation of `message-pop-to-buffer'." > > "notmuch's adaptation" or "a notmuch adaptation", or just "an adaptation". > I switched it to Emacsspeak, which here is: Like `message-pop-to-buffer' but enable `notmuch-message-mode' instead of `message-mode' and SWITCH-FUNCTION is mandatory. >> (let ((buffer (get-buffer name))) >> (if (and buffer >> (buffer-name buffer)) >> -- >> 2.29.1 >> _______________________________________________ >> notmuch mailing list -- notmuch@notmuchmail.org >> To unsubscribe send an email to notmuch-leave@notmuchmail.org > > dme. > -- > You bring light in.