From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yHboD0V7JmD2JwAA0tVLHw (envelope-from ) for ; Fri, 12 Feb 2021 12:57:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wKurC0V7JmD7MgAAB5/wlQ (envelope-from ) for ; Fri, 12 Feb 2021 12:57:41 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 273821CB23 for ; Fri, 12 Feb 2021 13:57:40 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C2A012063B; Fri, 12 Feb 2021 07:57:33 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 3E25E205C6 for ; Fri, 12 Feb 2021 07:57:31 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id 1DD446067F; Fri, 12 Feb 2021 07:57:31 -0500 (EST) Received: (nullmailer pid 2671489 invoked by uid 1000); Fri, 12 Feb 2021 12:57:29 -0000 From: David Bremner To: Michael J Gruber , notmuch@notmuchmail.org Subject: Re: [PATCH] fix FTBFS with glib In-Reply-To: References: Date: Fri, 12 Feb 2021 08:57:29 -0400 Message-ID: <8735y1wiiu.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: WT7USXSV2XEGBWNGZ6BZO7R34H3Q4SDS X-Message-ID-Hash: WT7USXSV2XEGBWNGZ6BZO7R34H3Q4SDS X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.98 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 273821CB23 X-Spam-Score: -1.98 X-Migadu-Scanner: scn0.migadu.com X-TUID: Vgd72Z/oFhUa Michael J Gruber writes: > With newer glib, notmuch FTBFS because of C linkage error. This is due > to a misplaced include (inside an extern "C") which was always there > but exposed only recently through this change in glib: > > https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715 > > Move to the include to the outside of the extern block. Thanks for the patch. I have some questions / comments. 1) What version of glib are we talking about? Is it released yet? 2) The reason this works is that gmime-extra.h has its own extern "C". If respinning the patch, it might be worth commenting on that. 3) I observed that just deleting #include "gmime-extra.h" from notmuch-private.h works fine, presumably because it is included where it is actually needed. In some sense this seems like a nicer solution. What do you think? d