From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UFdGIcmGjmAAtwAAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 13:02:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qKYCHcmGjmBdJAAA1q6Kng (envelope-from ) for ; Sun, 02 May 2021 11:02:33 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EBF8F22EE5 for ; Sun, 2 May 2021 13:02:32 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id E2721271D4; Sun, 2 May 2021 07:02:29 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 49021271D0 for ; Sun, 2 May 2021 07:02:27 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 2AAB960016; Sun, 2 May 2021 07:02:27 -0400 (EDT) Received: (nullmailer pid 871543 invoked by uid 1000); Sun, 02 May 2021 11:02:25 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 5/9] test: ruby: simplify test_ruby() In-Reply-To: <20210501115923.483816-6-felipe.contreras@gmail.com> References: <20210501115923.483816-1-felipe.contreras@gmail.com> <20210501115923.483816-6-felipe.contreras@gmail.com> Date: Sun, 02 May 2021 08:02:25 -0300 Message-ID: <8735v5o0u6.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: TDZXQC6IARHL4KA2FKQDXL5KIQZUYRS6 X-Message-ID-Hash: TDZXQC6IARHL4KA2FKQDXL5KIQZUYRS6 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619953353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=AXQyRHVzUW50Q6O9iAXxUjB8vVqhCwz26l8S2L54kpc=; b=WSLKxUL3nvXLDR7xPPLmQqmegt9nu4E6riBmSog6ZMAYPkW9ap/GhAwDggYA37ODYcyJUQ +S8JGyNrCfWyODOvNILOTBl7XxaSKnd5yJI3zzY/K3yqA5NHPc6y8M5MJhiMGcTfGGnkVL WPqT8sAdlXZ/8MemnQ0QDcTNQz4lHhNqD2S6EqGv8TxMG3gqPmEdPizsMwekIQNqHg7d+Q r7EEVDbTuORndk6q60jEvZxHacM3K8WIChd23NGU8pobAgCJ0ghbEAZ9dULlx7DSfhol6V M9bfjErR3nuShF/rK7vRtx8BlvI1y2wNiiKI917KtEN6dn/QeYnQtk3RjkhH5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619953353; a=rsa-sha256; cv=none; b=S8BoPl46uYwxBAOTbuOz5v3IkGZ5zzns2mgI0EE8W1SAyFebTWkz5fAkhyOCm6DL4NDLX8 u4bnvPUxzBy0BwEHwd7ecGTx9r1ywonEgbyvyNCQIqEkwDqo1+AzwwiuQxWkkJuWAgZRHd hYJSdfAuUkDnVm8o+0sIEFJLxoN8cDLYnNkKp+s7SCvfOJsr5G09tCLFErJlNyrue/prb5 XJH82YqsEsRJUP5K1ruKTu0TKobdzsauHpDJTB/8xrnYekuNGed+p4ecSfiGbdGndayM/9 4g2XSr4hjgOi7x8gVKARf8yEeX/VqLh+RmDvXEZpJxg2FiM7rbBfKqqvITN5JQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.10 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: EBF8F22EE5 X-Spam-Score: -2.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: FFzxOrrHDGM2 Felipe Contreras writes: > We always do test_expect_equal_file, so do it in test_ruby() directly. > > The only subtest where we don't (get non-existent file) can be easily > modified. I'm slightly hesitent since every other test ends with test_expect_*. OTOH it is self contained within this one file so I guess I can live with this change. d