From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4HqkKOlYnGCXCQEAgWs5BA (envelope-from ) for ; Thu, 13 May 2021 00:38:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0DtDJOlYnGCLNwAAB5/wlQ (envelope-from ) for ; Wed, 12 May 2021 22:38:33 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4145619DBB for ; Thu, 13 May 2021 00:38:33 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C430327185; Wed, 12 May 2021 18:38:29 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id E09E22717A for ; Wed, 12 May 2021 18:38:26 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id C9AD360018; Wed, 12 May 2021 18:38:26 -0400 (EDT) Received: (nullmailer pid 1321003 invoked by uid 1000); Wed, 12 May 2021 22:38:25 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH v2 03/10] ruby: improve general data get helper In-Reply-To: <20210504081749.715768-4-felipe.contreras@gmail.com> References: <20210504081749.715768-1-felipe.contreras@gmail.com> <20210504081749.715768-4-felipe.contreras@gmail.com> Date: Wed, 12 May 2021 19:38:25 -0300 Message-ID: <8735urfuhq.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: PVGUJXVVNS3X3SHUIAPQPFBBQAXKUIJU X-Message-ID-Hash: PVGUJXVVNS3X3SHUIAPQPFBBQAXKUIJU X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Ali Polatel , Austin Clements , Tomi Ollila , Ludovic LANGE , Daniel Kahn Gillmor X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620859113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yda0iIgeave28KxCMDzjmepVF1BuPQokyBbPdn1Woug=; b=hmlHAJgfIDUxp3K1hjBLPRQnwlPMe+GvCwvjawr6xJxRcoMyb7O2qdvIqdRkTsiJ5wF3cn E4HqSgc8UZD5ngkxCrox57XOLzaW8rBJKLvHiC2II0R6X7V6okO5IVmciBUuwbFg22f0Jf NyaLxnai++w/YKTuGrwS9SP25jSJkersCljiv0y4AoFceg4FPDS8ZNQJ0otsIxxPymIBMN gQbKJE5tdUzTJ7i6uy12osrdcRk3AHovurJjUfxbntf5MAEs07p3VKMggFmEYRs1o4sn21 aLA0cEMQarclrdhlOzSzmZ4XgRzkPcT9j/pgCsFzHFVmnBzab6WYm62ARPWoJA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620859113; a=rsa-sha256; cv=none; b=gsopmQJgbw1vOhuhGOLMtnyWpVoBWH0UQIBjb4r9HOwEwG4gUNq/RcxZF2Sp7lznAFVZE6 crkk6rvS7p+DMeHfDYbcTHobEdBFy9LfqK9+Kcmuz7Fz3FCDAU8wJzh6m/fqiZ0abWfU/H K10bKBfvdF9UIqQfooc6G34XHkd2KTELORV+DtwHjQ3C03SjlQeJAclWEwo4mt8eV/CeoE R8tP7CDjukMSQSQU7fS7LwiuhonDyrryv08pTiMTv5Zf4KkMeUcfj077voEhyVXyu2Qk+N Y0c05NHjS8a1sX2pS6CXl48llUFCyuQpKyDRYXd6eyf3LCkFAAo2e+lFHoXo7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 1.09 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 4145619DBB X-Spam-Score: 1.09 X-Migadu-Scanner: scn0.migadu.com X-TUID: PV7JEAsibNgr Felipe Contreras writes: > There's no need to do Check_Type, Data_Get_Struct calls > rb_data_object_get(), which already does that. Applied 1-3 to master. d