From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6NqLEL1KqmC+ZgAAgWs5BA (envelope-from ) for ; Sun, 23 May 2021 14:29:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IHZYDL1KqmDAZQAAB5/wlQ (envelope-from ) for ; Sun, 23 May 2021 12:29:49 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C2BDCAC6 for ; Sun, 23 May 2021 14:29:48 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 388552AAF2; Sun, 23 May 2021 08:29:46 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id D2FD127187 for ; Sun, 23 May 2021 08:29:43 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id C52C35FD25; Sun, 23 May 2021 08:29:43 -0400 (EDT) Received: (nullmailer pid 2475506 invoked by uid 1000); Sun, 23 May 2021 12:29:41 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 2/3] ruby: add keyword arguments to db.query In-Reply-To: <20210501120448.484082-3-felipe.contreras@gmail.com> References: <20210501120448.484082-1-felipe.contreras@gmail.com> <20210501120448.484082-3-felipe.contreras@gmail.com> Date: Sun, 23 May 2021 09:29:41 -0300 Message-ID: <8735udskei.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 6F27VFLAYNHUGCIOYSRTHI47MADQO7TW X-Message-ID-Hash: 6F27VFLAYNHUGCIOYSRTHI47MADQO7TW X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Ludovic LANGE , Stefano Zacchiroli X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621772988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mbXMsVSuJYwWiHJP12F6v8dzUdwvy47FV3fIyzRzny8=; b=omGsMd4rNXS0bXXO5egm/F+lJnDTtREjem8aIvkTnZ4n+rjnOOBrXBsKbx1u9P7sxkwv7d L8Fad8wnYWYEPNn1LzUSDPVzZ/vPGzL6o/GoJdJSWSVYjjn6hpmD9l2O1n1BdlOuEosVwD kYXpL9V8m+hWPmS0ErT7NH90TyyQOdItXawAYN+5KYILJTA/KpDFElxm6+Bgvt538S47lY 4MpevDYxMFNctLPj765s4Pl8ksV/EedY1w7A2vqLH0ycAY6QAJy3u7/+opPbTT16YY5t5X sk2nfKkSaaL8GX644f1lsxT1dIK6sca+iBJtBhtstofM+zglfJYyvUUxqqT5wg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621772988; a=rsa-sha256; cv=none; b=fvUgxd6B0OfAIDIBFmEBvhG6XzeAvewKM1AgVzopjdEKGwz7kREB2qj1rXR3l69P/fKB6T NxsLvxrxPllEnYOZ9box6DGU0OYfa2tSPXVdc5jRk08OAfKf43SE/DbKG/nGGWi+1UEhdE cP0Qq1mSgHgnOPcs+joehAsKXVbSkLH3JykMyVdffcUE3JuGXvcT71byicYs/SGuLkVN1A qa+4DeF3VFuAMes6q6sq/x+rPr9Bff7mIG++lvjDv8XZNJEQaQ0Xk/CHArcVbW3Vka5aNr duZa3/mf0KD9ggAJyB7YGQXUPIASkxWRJUmAhSZD/XochaoKOaHxDvjn9PAlOQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.58 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 6C2BDCAC6 X-Spam-Score: -0.58 X-Migadu-Scanner: scn0.migadu.com X-TUID: 06Nyuj4Da2By Felipe Contreras writes: > That way we don't need pass them to the query object ourselves. LGTM, but when I tried to resolve the conflicts I messed something up and the ruby sort test(s) started failing. Rebase please? d