unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [RFC PATCH] python-cffi out-of-tree build
Date: Sun, 31 Oct 2021 08:40:28 -0300	[thread overview]
Message-ID: <8735oh8lsj.fsf@tethera.net> (raw)
In-Reply-To: <20210217213600.10268-1-tomi.ollila@iki.fi>

Tomi Ollila <tomi.ollila@iki.fi> writes:

> setup.py and _build.py to refer some other files based on directory
> where setup.py is located (os.path.dirname(sys.argv[0]).
>
> Dropped bindings/python-cffi/version.txt and refer ../../version.txt
> instead -- _build.py already refers ../../lib so why have version.txt
> twice (with identical content).
>
> Dropped copying of bindings/python-cffi source files to the build
> directory bindings/python-cffi in configure.

Apologies, I think I did not read this discussion very carefully
before. I guess [1] is an alternative to the first two points. I'm not
sure which approach is better. Mine is a bigger hammer, but maybe that
could be useful in the future?

The patch at [1] does not (by itself) allow the third change, but
probably some similar hacking of setup.py, but using the newly created
_notmuch_config.py would work.

Tomi, did you happen to test "pip install ." with your approach? I'm
afraid your patch doesn't (easily) apply anymore so I was too lazy to
test myself.

Cheers,

db

[1]: id:20211031100354.1697379-1-david@tethera.net

  parent reply	other threads:[~2021-10-31 11:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 21:36 [RFC PATCH] python-cffi out-of-tree build Tomi Ollila
     [not found] ` <87a6m015ys.fsf@tethera.net>
2021-08-10 20:39   ` [Tomi Ollila] " Floris Bruynooghe
2021-10-05 12:22     ` David Bremner
2021-10-31 11:40 ` David Bremner [this message]
2021-10-31 19:28   ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735oh8lsj.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).