From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CGk6DqE+l2JgxQAAbAwnHQ (envelope-from ) for ; Wed, 01 Jun 2022 12:25:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uDPPDaE+l2I2LgEAauVa8A (envelope-from ) for ; Wed, 01 Jun 2022 12:25:37 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D89F0BB86 for ; Wed, 1 Jun 2022 12:25:36 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 807F45F7B2; Wed, 1 Jun 2022 10:25:34 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id C04245F7AF for ; Wed, 1 Jun 2022 10:25:31 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 092505FBD7; Wed, 1 Jun 2022 06:25:31 -0400 (EDT) Received: (nullmailer pid 2724063 invoked by uid 1000); Wed, 01 Jun 2022 10:25:30 -0000 From: David Bremner To: Jose A Ortega Ruiz , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: notmuch-show-header-line: allow format strings and functions In-Reply-To: <871qw8iu6i.fsf@gnus.jao.io> References: <20220518192956.1440103-1-jao@gnu.org> <20220518192956.1440103-2-jao@gnu.org> <87zgj34zuf.fsf@tethera.net> <87czfzg6sk.fsf@gnus.jao.io> <87a6aw20qm.fsf@tethera.net> <871qw8iu6i.fsf@gnus.jao.io> Date: Wed, 01 Jun 2022 07:25:30 -0300 Message-ID: <8735go1y05.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 4IGIGTCLQEN22KCWJMI5QGPYPTZBF4P3 X-Message-ID-Hash: 4IGIGTCLQEN22KCWJMI5QGPYPTZBF4P3 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654079136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=6DhPPBOGsIzr0y9A7553x5E0SjwwDAk+HD/nNj3Ipmo=; b=boxX7hTCgkkyaUtxt3MhvTQrEoqkkaQ9003WM05rLl2w1DOYkf4PHKcb50KlkyUqc1jZpF K0Fsjx5qhaeop7GR/FFnskBGekC+UcoaFM1CSIctNNnGPKzGCPNdMAMyodaPayFVZeitNG N6W6twTFru4+ArWa/wTjA1aPoF2R+4dp5C4PM7Ot73VOICr9GEG9AziRoNXVoQTJ/YTiPY P/JGFL6s96sPjXs1MSqvvY1DdhNPf5eVuZ7N5CjOnoYNCFe2Q9O1pnL4EOKHtEU6+oUbLJ WWpNZ7uVTkevikIrj+rY9QTB323JxqqJQOVxV4vhZ7k1pnzKZkROh5+gNPZPVA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654079136; a=rsa-sha256; cv=none; b=qrwyl0VdeygZYvB3EDM1uApNv4CnJZ8kvRdlqq0u4k6wGL5KfHodvgbmapoGklh+OxbRxZ f7cVQ+ecVacotGDLqJ245AcGDlNU0AIJGxcJM+MJ0bVESHVI7U8VBuVvYfmc4X5CYegUFP yKA5HdV5KyfQAML6r3HUsPf5LL8JK7aoAeSAduh80ZXuQRtK70GMPaxJHgblEwA0CZiIYD zxDuuL03chlI5/pMUefWJEwB2UiOwtJ2tikz2FjLnOYii/5WsUWyoM4Vk0EUK4Uven6az5 O3sPlI5X5wt7W1iVDzwQNDeMxOFkW4BDS/hQcEUS4vUYfgZuFV7k8LNsrapShg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: D89F0BB86 X-Spam-Score: -2.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: WGNPczghn3iC Jose A Ortega Ruiz writes: > On Wed, Jun 01 2022, David Bremner wrote: > >> Fair enough. But since the calling is not obvious to the casual user >> (*cough* or me), maybe mention the availability of message properties >> in the docstring. > > Yes, good idea. I've done just that in a new version (v4) of the patch. > I've also noticed the variable notmuch-show-header-line is already > documented in doc/notmuch-emacs.rst (by importing its docstring): do we > need to add documentation elsewhere? As long as you are happy enough with the way it imports (e.g. run make sphinx-html), that's fine. I did notice one typo "variabale", but I can amend that if you are otherwise happy. d