From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OAxcI/1lJGSTqgAASxT56A (envelope-from ) for ; Wed, 29 Mar 2023 18:23:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +MNTIv1lJGQANgEAG6o9tA (envelope-from ) for ; Wed, 29 Mar 2023 18:23:25 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 57A5E12622 for ; Wed, 29 Mar 2023 18:23:25 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 579A05F82D; Wed, 29 Mar 2023 16:23:24 +0000 (UTC) Received: from out-6.mta1.migadu.com (out-6.mta1.migadu.com [IPv6:2001:41d0:203:375::6]) by mail.notmuchmail.org (Postfix) with ESMTPS id 407105F826 for ; Wed, 29 Mar 2023 16:23:21 +0000 (UTC) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boula.in; s=key1; t=1680107000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R42eZcoA0+N+K8aRWsjFg6T5mTBXJtcZvOzqlDvm8hI=; b=ZuhpHQJ3rm53dIxcPBQWwmUca6K2sbvNvJnVnTPWiKvNpc7V74krD2aD9KRWrAn2GQUkBE YkLr7I0zn/OoKgo7M+RwCUUEBANIBgtcf8mxgWLcse/dFdgzpITIrJN+z1z2vBI2xPvJE6 dqaFd45wpgJPrpryhyCPI2F0LErn7ELfzUWexOOWLB7sK67jpOPwiYXqnOmT+tY0isn844 GgXc1lCSfpYkWB2Plr0dKhQKTfL1bgI7SaJMMFAogiZy679OqlFMAzLcMaJ90sZqaMsDQh RcYoF4B9LxrrdRWPIp0pUdIoPhqN/Jjk7PCa8RMSfV+6ILQl97wjbeC4w4hUHQ== From: Kevin Boulain To: David Bremner Subject: Re: [PATCH 2/2] lib/message-property: sync removed properties to the database In-Reply-To: <87v8ij6ben.fsf@tethera.net> References: <20230301205149.297637-1-kevin@boula.in> <20230301205149.297637-2-kevin@boula.in> <87jzzyycmt.fsf@boula.in> <87v8ij6ben.fsf@tethera.net> Date: Wed, 29 Mar 2023 18:23:20 +0200 Message-ID: <87355nbk7b.fsf@boula.in> MIME-Version: 1.0 Message-ID-Hash: B7T7JBL6CT7TYHWMFPZ5VPPRFMBRLAQX X-Message-ID-Hash: B7T7JBL6CT7TYHWMFPZ5VPPRFMBRLAQX X-MailFrom: kevin@boula.in X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680107005; a=rsa-sha256; cv=none; b=PYoacaAkwLAiDc8GmA+laIhnszmLsnUUAQmJ0YPRAdq9D1baRHPPqaF6eBDY8i5PHghY7S vLrjNZGK83EZtpu3mBnLey/INpz1bqJ+adrk7kyL1/O07kbunPrqQl60lJxKFz9df3yRTW zKjoDNGdUhIMnL8MGZrBAedz9BGgPui7W953P48+/NfHOTyczuu8kPb0d+h3q3qUzM/rI0 lYOHCdblM8mrN3ujbVwDNjq9KIcUIYWK1ES9GnOpL9eKEnRLtNQxRK4DZyUpEUlsIvpwCP w7muI8r98VUlsu76DHd7JW8eULE73R3pWxpkVRExadmXxwSHWSszOUnwfB8Qqw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=boula.in header.s=key1 header.b=ZuhpHQJ3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=boula.in (policy=quarantine); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680107005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=330cqt9u+urXWXaJGSRrg59DXWOZulZRE9lsNcEwRsA=; b=XwzSWYi1PkbWa45M/u2de3frdr8jQyjMmvtUD4uS8b/CYf7d8faVcSPD9QnxjqxZbni4gU 7aG2McWcMABpptoYXaj07eJO99NtDv7vwxg/7Aeuqx2lzmUPG3rhpiqbcSQCMMmOyXy0hH 9F5JiglnsmggqInIiDziUsE4YBldXnopTp89QmMdvjBBstyFT0m9YhwZqpI2iHJmjiw2ma YMQ6UV1I4rTeg9sCAhVb8XS16pKXn1NXHj8lerC/AsBPzNJFSY4UYzijzhSUtlxjsOC48a x9rHvJ5pjON/1Q7t2iraUnK2wk1x1PDWTlmyffQhVVXrLJKZDK68RJrTI733EA== X-Migadu-Spam: Yes X-Migadu-Spam-Score: 6.00 X-Spam-Score: 6.00 X-Migadu-Queue-Id: 57A5E12622 X-Migadu-Scanner: scn0.migadu.com X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=boula.in header.s=key1 header.b=ZuhpHQJ3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=boula.in (policy=quarantine); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-TUID: A5usWGJuQmcJ On 2023-03-29 at 08:32 -03, David Bremner wrote: > It would be nice to structure this in terms of a known broken test > (perhaps modify the existing one to reopen the database and dump the properties) > that is then fixed by patch adding the sync. I have restructured the commits to hopefully make that clearer. I've optimized for the smallest diff but I can rewrite some of the tests if you'd prefer.