From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IFzALMlhJWS+vwAASxT56A (envelope-from ) for ; Thu, 30 Mar 2023 12:17:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cHxzLMlhJWT1NwAAauVa8A (envelope-from ) for ; Thu, 30 Mar 2023 12:17:45 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8E5B0C27A for ; Thu, 30 Mar 2023 12:17:45 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 9F32B5F831; Thu, 30 Mar 2023 10:17:42 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id CBFA75F802 for ; Thu, 30 Mar 2023 10:17:40 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id AD0AD5FB82; Thu, 30 Mar 2023 06:17:39 -0400 (EDT) Received: (nullmailer pid 2756535 invoked by uid 1000); Thu, 30 Mar 2023 10:17:37 -0000 From: David Bremner To: Kevin Boulain , notmuch@notmuchmail.org Subject: Re: [PATCH v3 1/2] test: uncaught exception when editing properties of a removed message In-Reply-To: <20230329161958.155505-1-kevin@boula.in> References: <87zg7v6dow.fsf@tethera.net> <20230329161958.155505-1-kevin@boula.in> Date: Thu, 30 Mar 2023 07:17:37 -0300 Message-ID: <87355m5yri.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: CIZKEBI7MZIZ7NIMAWXZZNN6NQN4XH5E X-Message-ID-Hash: CIZKEBI7MZIZ7NIMAWXZZNN6NQN4XH5E X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kevin Boulain X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Migadu-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-Migadu-Queue-Id: 8E5B0C27A Authentication-Results: aspmx1.migadu.com; none X-Spam-Score: -4.00 X-TUID: 4Re4SzK1LFC1 Kevin Boulain writes: > These two functions don't fail gracefully when editing a removed > message: > BROKEN edit property on removed message without uncaught exception > --- T610-message-property.20.EXPECTED 2023-02-27 11:33:25.792764376 +0000 > +++ T610-message-property.20.OUTPUT 2023-02-27 11:33:25.793764381 +0000 > @@ -1,2 +1,3 @@ > == stdout == > == stderr == > +terminate called after throwing an instance of 'Xapian::DocNotFoundError' > Series applied to master, thanks! d