From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6DAZBWXSXmezBgEAe85BDQ:P1 (envelope-from ) for ; Sun, 15 Dec 2024 12:58:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 6DAZBWXSXmezBgEAe85BDQ (envelope-from ) for ; Sun, 15 Dec 2024 13:58:13 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=cassou.me header.s=dkim header.b=ZW2+7uCW; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=cassou.me (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734267493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=+Blpey6eWMtyZJw7M29eluEfzxl8hPZWGfphXwq1cZg=; b=P9ZIBcpBHz6LhZ6NRCGyVgCGL/mTJUwoCraSflTkJoYLmyZ2AoidLV/2uIG0Y+8BNz9g63 viaKjBSYS4zgO3FuqgDHMiepKbO4IVPZF5LgitbMzzyKd58IaVmDbPSw996qaJj4aczbPP vWugnxh0OUUU2VYMIJJN/NXn4lvG6rBR6MbFcRi/ug+mmfPbrs4eJEuKOPzT2bmPY+VekQ 9fcxGKGDlFkljPZn24p/3mJUuix7zbBVm5mu3+RjOzuqoEExewroAnGRug/a/21G6NTcT0 n8d8zixhT2lxPN0n+6orSCbdyAFN1b3cdGEkBaGT5LPcbBQc13VFRlEUcBX95w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=cassou.me header.s=dkim header.b=ZW2+7uCW; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=cassou.me (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734267493; a=rsa-sha256; cv=none; b=RUv9FiRavYfIuuexCH/C3MBJd6cdtexb/4UkyPsazuruKxJrLzwPCIlrHl+3wPdwYg/wJv TZaJcVO+8QVHDMbacihGyqyDAtn1hR0vAUB6KzoRvHnydv3sbSxPzCxrrp6JQ1+UT7vPQo kMeeSLiGj5EJHlFwfMvgZ0fN22bSsaP7/59iJdB9s7HRl84I4CB+jKsFUID8eKOY3+aR81 qvQOpysxVZ+3+12+Kl98c1W6qq1vEl993Z59bIEhhVo1s/1GBHkASWMVs/+ON1Ebc5Fcda QhOw8lwXbhbAyiYfsnej41qAeKI019Z/wdYU+qLkDfbLTYhpfx2NITfdNZ86Ow== Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B31531EEC for ; Sun, 15 Dec 2024 13:58:11 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id B7B3A5E29F; Sun, 15 Dec 2024 12:47:50 +0000 (UTC) Received: from mail.reprendre.net (mail.reprendre.net [IPv6:2001:910:1410:501::1]) by mail.notmuchmail.org (Postfix) with ESMTPS id C86CF5E16C for ; Sun, 15 Dec 2024 12:47:46 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7BF0C2CA7FB; Sun, 15 Dec 2024 13:47:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=dkim; t=1734266864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oSCvgHhH8u1aJYNBbDnR35B/y4NYYpnFAKewW/bdTLs=; b=ZW2+7uCWisCstSuqeuo8Ds2QWy/u4SjXh7CoujcZ5Uc/IijLqKKC7D9HFxtQ8P+SW9ttaM C5Z1V48ErFhs2Z+nngeCjb4UlTpsUNd/Wc7x1hiVK1i8wN2lx3GcQUKeOXRN201j58NEsV ehuAkvz1xVgDqns9QDZI5HfnSu06op1ZDLLTWrY8DS8dfpGrqU5N0V2bz6EDjtL0seO6+o kpte/SMMcPAtP9vJs4GMwbWarBgLO7ffF3QRKPKDuKGGfnPI2Oe9JPMI4dF6yhHgxUyfGD V5vA1g8g7ySTdDteqiu2N2fzKCzw3lurFR40GzdRaYRXFq9vXUr1z4/WKcrBog== From: Damien Cassou To: Pengji Zhang , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs/show: Only recenter interactively In-Reply-To: <87o71dguje.fsf@pengjiz.com> References: <20241123151601.16201-2-damien@cassou.me> <87o71dguje.fsf@pengjiz.com> Date: Sun, 15 Dec 2024 13:47:42 +0100 Message-ID: <8734ipdsep.fsf@cassou.me> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Message-ID-Hash: 7VFL7EQFRFTTI3ANNPX6HVOQR4JRIN4J X-Message-ID-Hash: 7VFL7EQFRFTTI3ANNPX6HVOQR4JRIN4J X-MailFrom: damien@cassou.me X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Migadu-Queue-Id: B31531EEC X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -0.44 X-Spam-Score: -0.44 X-TUID: FBtCfk9c8unH Hi, thank you very much for your feedback. I have a question though: Pengji Zhang writes: > 'notmuch-show-goto-message' is not a command. So it is always called > non-interactively. That makes sense. This function is, for example, called by `notmuch-show-apply-state' which is itself called by `notmuch-show--build-buffer' which is itself called by `notmuch-show-refresh-view'. If I go with the idea of adding an `adjust` parameter as you (and Emacs maintainers) suggest, does it mean that I should add this parameter to all these functions? Or maybe should I move the call to `notmuch-show-message-adjust' from `notmuch-show-goto-message' to interactive functions that (possibly indirectly) make use of it (e.g., `notmuch-show-refresh-view' and `notmuch-show-filter-thread'). The second solution seems to make the most sense to me because it is only in the interactive function that the developer really know what should be shown to the user and why. Do you have another idea or a preference? -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill