Re: [PATCH] emacs/show: Only recenter interactively

[Damien Cassou <damien@cassou.me>]

Hi,

thank you very much for your feedback. I have a question though:

Pengji Zhang <me@pengjiz.com> writes:
> 'notmuch-show-goto-message' is not a command. So it is always called
> non-interactively.

That makes sense. This function is, for example, called by
`notmuch-show-apply-state' which is itself called by
`notmuch-show--build-buffer' which is itself called by
`notmuch-show-refresh-view'. If I go with the idea of adding an `adjust`
parameter as you (and Emacs maintainers) suggest, does it mean that I
should add this parameter to all these functions? Or maybe should I move
the call to `notmuch-show-message-adjust' from
`notmuch-show-goto-message' to interactive functions that (possibly
indirectly) make use of it (e.g., `notmuch-show-refresh-view' and
`notmuch-show-filter-thread'). The second solution seems to make the
most sense to me because it is only in the interactive function that the
developer really know what should be shown to the user and why.

Do you have another idea or a preference?

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill