From: Carl Worth <cworth@cworth.org>
To: Sebastian Spaeth <Sebastian@SSpaeth.de>,
Notmuch developer list <notmuch@notmuchmail.org>
Subject: Re: [PATCH v2] emacs: Reuse rather than reinvent message header filtering
Date: Thu, 03 Jun 2010 17:06:14 -0700 [thread overview]
Message-ID: <871vcnfyq1.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1272532201-8742-1-git-send-email-Sebastian@SSpaeth.de>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Thu, 29 Apr 2010 11:10:01 +0200, Sebastian Spaeth <Sebastian@SSpaeth.de> wrote:
> In notmuch-mua-reply we were filtering out the Subject and To headers
> manually in a loop, but message mode offers a nice function for
> exactly that. Simplify the code by using it. Also, as notmuch-mua-mail
> already sorts and hides headers that we want sorted and hidden, we can
> safely remove those 2 functions from here as well. Also remove the
> (require 'cl), the only reason for its existence was the now removed
> "loop" function.
>
> Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
> ---
> Also removed (require 'cl) as per dme's suggestion.
Lovely. Thanks for the patch, Sebastian, (and for the review, David).
I've committed this and expect to push it soon.
-Carl
--
carl.d.worth@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2010-06-04 0:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 8:47 [PATCH] emacs: Reuse rather than reinvent message header filtering Sebastian Spaeth
2010-04-29 9:00 ` David Edmondson
2010-04-29 9:10 ` [PATCH v2] " Sebastian Spaeth
2010-06-04 0:06 ` Carl Worth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871vcnfyq1.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=Sebastian@SSpaeth.de \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).