unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/3] Add 'compose' command
Date: Wed, 18 Apr 2012 18:41:52 +0400	[thread overview]
Message-ID: <871unlm79r.fsf@gmail.com> (raw)
In-Reply-To: <CAMP44s0qHWGAiGWbKqa3pTJWbpvshoNpoc6EezJmDjE8xQ3ZYA@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> On Wed, Apr 18, 2012 at 4:43 PM, Dmitry Kurochkin
> <dmitry.kurochkin@gmail.com> wrote:
>> Hi Felipe.
>>
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula <jani@nikula.org> wrote:
>>>
>>>> Running "notmuch compose" more than once within a second would result in
>>>> identical message ids for the messages, which is not a good idea. That's
>>>> not likely in interactive use, but the notmuch cli is highly scriptable,
>>>> so someone is bound to hit this.
>>>>
>>>> Some paranoid might also be worried about "leaking" the time you run
>>>> "notmuch compose"... which may be different from the actual time you
>>>> send the message.
>>>
>>> It's still better than the current situation; nothing. In any case,
>>> people that have not needed this would not be affected; their UI would
>>> override the Message-ID.
>>>
>>
>> I disagree.  If notmuch CLI generates a Message-ID, it must be a good
>> one.  Otherwise we make users falsely believe that they do have a proper
>> Message-ID while in fact they do not.  And that would bite them sooner
>> or later.
>
> And then they'll report it, and we would fix it.
>
> Anyway, everything comes from a patch, so, do you have a patch,
> pseudo-code, or even a suggestion?
>

A patch needs some positive reviews to be accepted.  Replying to
comments with "make a better patch" may not be the best strategy for
getting your patches accepted.

I do not have a patch.  As for a suggestion, I would start with some
googling.  If you did that, you would probably find the gmime function
kindly pointed out by Jani.

Regards,
  Dmitry

> -- 
> Felipe Contreras

  reply	other threads:[~2012-04-18 14:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-18 12:39 [PATCH v2 0/3] composing patches Felipe Contreras
2012-04-18 12:39 ` [PATCH v2 1/3] Add 'compose' command Felipe Contreras
2012-04-18 13:06   ` Jani Nikula
2012-04-18 13:34     ` Felipe Contreras
2012-04-18 13:43       ` Dmitry Kurochkin
2012-04-18 14:11         ` Felipe Contreras
2012-04-18 14:41           ` Dmitry Kurochkin [this message]
2012-04-18 15:45             ` Felipe Contreras
2012-04-18 14:20       ` Jani Nikula
2012-04-18 15:39         ` Felipe Contreras
2012-04-18 16:00           ` Tomi Ollila
2012-04-18 16:10             ` Dmitry Kurochkin
2012-04-18 16:34           ` Jani Nikula
2012-04-19  9:31             ` Tomi Ollila
2012-04-19 14:03               ` Felipe Contreras
2012-04-18 12:39 ` [PATCH v2 2/3] reply: add message-id header Felipe Contreras
2012-04-18 13:09   ` Jani Nikula
2012-04-18 17:27     ` Adam Wolfe Gordon
2012-04-18 19:44     ` Felipe Contreras
2012-04-18 12:39 ` [PATCH v2 3/3] reply: add user-agent field Felipe Contreras
2012-04-18 17:36 ` [PATCH v2 0/3] composing patches Adam Wolfe Gordon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871unlm79r.fsf@gmail.com \
    --to=dmitry.kurochkin@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).