From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Jani Nikula <jani@nikula.org>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v2 4/5] cli: new crypto verify flag to handle verification
Date: Sat, 19 May 2012 09:28:57 -0700 [thread overview]
Message-ID: <871umg9lti.fsf@servo.finestructure.net> (raw)
In-Reply-To: <878vgoe7i5.fsf@nikula.org>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
On Sat, May 19 2012, Jani Nikula <jani@nikula.org> wrote:
>> + /* decryption implies verification */
>> + if (params.crypto.decrypt)
>> + params.crypto.verify = TRUE;
>
> This does not change existing behaviour, only makes it more obvious
> (which is good), but this seems to be missing from the man page. I
> presume technically decryption doesn't have to imply verification, but
> it's probably a good thing. It should be documented, but does not have
> to be a part of this series.
Well that's very strange. I was sure I mentioned that in the man page
back when I originally added decryption support. But apparently I
didn't. I'll submit a separate patch to fix the documentation.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-05-19 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 17:32 [PATCH v2 0/5] cli: improve handling of crypto parameters and contexts Jameson Graef Rollins
2012-05-18 17:32 ` [PATCH v2 1/5] cli: new crypto structure to store crypto contexts and parameters Jameson Graef Rollins
2012-05-18 17:32 ` [PATCH v2 2/5] cli: modify mime_node_open to take crypto struct as argument Jameson Graef Rollins
2012-05-18 17:32 ` [PATCH v2 3/5] cli: modify mime_node_context to use the new notmuch_crypto_t Jameson Graef Rollins
2012-05-18 17:32 ` [PATCH v2 4/5] cli: new crypto verify flag to handle verification Jameson Graef Rollins
2012-05-18 17:32 ` [PATCH v2 5/5] cli: lazily create the crypto gpg context only when needed Jameson Graef Rollins
2012-05-18 19:21 ` Austin Clements
2012-05-18 19:45 ` Jameson Graef Rollins
2012-05-18 20:37 ` Daniel Kahn Gillmor
2012-05-18 20:42 ` Jameson Graef Rollins
2012-05-19 11:26 ` [PATCH v2 4/5] cli: new crypto verify flag to handle verification Jani Nikula
2012-05-19 16:28 ` Jameson Graef Rollins [this message]
2012-05-18 19:09 ` [PATCH v2 3/5] cli: modify mime_node_context to use the new notmuch_crypto_t Austin Clements
2012-05-18 19:17 ` Jameson Graef Rollins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871umg9lti.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).