From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/7] emacs: JSON-based search cleanups
Date: Fri, 13 Jul 2012 19:12:37 +0100 [thread overview]
Message-ID: <871ukf8r8q.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1342140319-19859-1-git-send-email-amdragon@mit.edu>
On Fri, 13 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> This series builds on the JSON-based search series [0] to clean up
> several other aspects of search-mode. It removes constraints on the
> formatting of tags in the result line (you can even leave them out
> entirely), it recolors lines when tags change, it adds supports for
> multi-line result formats, and rendering big search buffers should be
> less quadratic (it might even be linear). Much of this derives from
> having a single object representation of a result (the JSON plist) and
> a simple method for rendering it to the buffer.
Overall this series looks excellent. I have reviewed all the patches
except patch 4/7 (I will need to work out how macros work to review
that) and they seem fine modulo the small comments I have made.
One final comment: I couldn't persuade the defcustom search result to
take a newline symbol to test multiline results. It seems to escape
entries of \n, and I couldn't enter returns (and ^Q return didn't work
either).
It was easy by editing the option in my .emacs file and then seemed to
work as expected.
Best wishes
Mark
>
> [0] 1341870162-17782-1-git-send-email-amdragon@mit.edu
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-07-13 18:12 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 0:45 [PATCH 0/7] emacs: JSON-based search cleanups Austin Clements
2012-07-13 0:45 ` [PATCH 1/7] emacs: Record thread search result object in a text property Austin Clements
2012-07-13 0:45 ` [PATCH 2/7] emacs: Use text properties instead of overlays for tag coloring Austin Clements
2012-07-13 17:59 ` Mark Walters
2012-07-13 18:43 ` Austin Clements
2012-07-13 0:45 ` [PATCH 3/7] emacs: Update tags by rewriting the search result line in place Austin Clements
2012-07-13 17:57 ` Mark Walters
2012-07-13 18:33 ` Austin Clements
2012-07-13 0:45 ` [PATCH 4/7] emacs: Use result text properties for search result iteration Austin Clements
2012-07-13 0:45 ` [PATCH 5/7] emacs: Replace other search text properties with result property Austin Clements
2012-07-13 0:45 ` [PATCH 6/7] emacs: Allow custom tags formatting Austin Clements
2012-07-13 0:45 ` [PATCH 7/7] emacs: Fix navigation of multi-line search result formats Austin Clements
2012-07-13 17:21 ` Mark Walters
2012-07-13 17:53 ` Austin Clements
2012-07-13 18:02 ` Mark Walters
2012-07-13 18:12 ` Mark Walters [this message]
2012-07-14 3:28 ` [PATCH 0/7] emacs: JSON-based search cleanups Austin Clements
2012-07-14 3:43 ` [PATCH v2 " Austin Clements
2012-07-14 3:43 ` [PATCH v2 1/7] emacs: Record thread search result object in a text property Austin Clements
2012-07-14 3:43 ` [PATCH v2 2/7] emacs: Use text properties instead of overlays for tag coloring Austin Clements
2012-07-14 3:43 ` [PATCH v2 3/7] emacs: Update tags by rewriting the search result line in place Austin Clements
2012-07-14 3:43 ` [PATCH v2 4/7] emacs: Use result text properties for search result iteration Austin Clements
2012-07-14 19:31 ` Jameson Graef Rollins
2012-07-14 19:35 ` Jameson Graef Rollins
2012-07-14 19:50 ` Austin Clements
2012-07-14 20:01 ` Austin Clements
2012-07-14 21:13 ` Jameson Graef Rollins
2012-07-14 21:51 ` Austin Clements
2012-07-14 23:02 ` Jameson Graef Rollins
2012-07-14 21:15 ` Mark Walters
2012-07-14 3:43 ` [PATCH v2 5/7] emacs: Replace other search text properties with result property Austin Clements
2012-07-14 3:43 ` [PATCH v2 6/7] emacs: Allow custom tags formatting Austin Clements
2012-07-14 3:43 ` [PATCH v2 7/7] emacs: Fix navigation of multi-line search result formats Austin Clements
2012-07-14 19:06 ` [PATCH v2 0/7] emacs: JSON-based search cleanups Jameson Graef Rollins
2012-07-14 23:02 ` [PATCH v3 0/8] " Austin Clements
2012-07-14 23:02 ` [PATCH v3 1/8] emacs: Record thread search result object in a text property Austin Clements
2012-07-14 23:02 ` [PATCH v3 2/8] emacs: Use text properties instead of overlays for tag coloring Austin Clements
2012-07-14 23:02 ` [PATCH v3 3/8] emacs: Update tags by rewriting the search result line in place Austin Clements
2012-07-14 23:02 ` [PATCH v3 4/8] emacs: Use result text properties for search result iteration Austin Clements
2012-07-14 23:02 ` [PATCH v3 5/8] emacs: Replace other search text properties with result property Austin Clements
2012-07-14 23:02 ` [PATCH v3 6/8] emacs: Allow custom tags formatting Austin Clements
2012-07-14 23:02 ` [PATCH v3 7/8] emacs: Fix navigation of multi-line search result formats Austin Clements
2012-07-14 23:02 ` [PATCH v3 8/8] News for search cleanups Austin Clements
2012-07-15 8:34 ` [PATCH v3 0/8] emacs: JSON-based " Mark Walters
2012-07-15 21:14 ` Jameson Graef Rollins
2012-07-15 16:27 ` Mark Walters
2012-07-15 18:00 ` Austin Clements
2012-07-15 18:14 ` Mark Walters
2012-07-21 17:55 ` [PATCH v4] " Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ukf8r8q.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).