From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 13039431E64 for ; Sun, 2 Jun 2013 10:48:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XwzwycU3EG09 for ; Sun, 2 Jun 2013 10:48:12 -0700 (PDT) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 08052431FBC for ; Sun, 2 Jun 2013 10:48:12 -0700 (PDT) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1UjCO1-0007IF-QV; Sun, 02 Jun 2013 18:48:10 +0100 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) (envelope-from ) id 1UjCO1-0005jJ-FN; Sun, 02 Jun 2013 18:48:09 +0100 From: Mark Walters To: david@tethera.net, notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: remove hardcoded defaults values from docstrings In-Reply-To: <1370181885-23021-1-git-send-email-david@tethera.net> References: <1370181885-23021-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1 (i486-pc-linux-gnu) Date: Sun, 02 Jun 2013 18:47:59 +0100 Message-ID: <871u8kl7zk.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 93.97.24.31 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: ac9afe20eeab894449b7ed0fbc4d1187 (of first 20000 bytes) X-SpamAssassin-Score: -0.0 X-SpamAssassin-SpamBar: / X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -0.0 points. Summary of the scoring: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * -0.0 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean Cc: David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jun 2013 17:48:20 -0000 both of these LGTM +1. Note there are still some (an?) occurrences of this: eg notmuch-search-archive-thread, and there is one in pick. But these might as well go in anyway. Best wishes Mark On Sun, 02 Jun 2013, david@tethera.net wrote: > From: David Bremner > > These functions refer to default values of variables, but it seems > less confusing and less likely to get out of date to just allow the > user to follow the help cross-reference links. > --- > emacs/notmuch-show.el | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > another proposed change from our notmuch-pick discussions. > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 613e666..600e802 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -1835,10 +1835,9 @@ search results instead." > "Archive each message in thread. > > Archive each message currently shown by applying the tag changes > -in `notmuch-archive-tags' to each (remove the \"inbox\" tag by > -default). If a prefix argument is given, the messages will be > -\"unarchived\", i.e. the tag changes in `notmuch-archive-tags' > -will be reversed. > +in `notmuch-archive-tags' to each. If a prefix argument is given, > +the messages will be \"unarchived\", i.e. the tag changes in > +`notmuch-archive-tags' will be reversed. > > Note: This command is safe from any race condition of new messages > being delivered to the same thread. It does not archive the > @@ -1865,10 +1864,9 @@ buffer." > "Archive the current message. > > Archive the current message by applying the tag changes in > -`notmuch-archive-tags' to it (remove the \"inbox\" tag by > -default). If a prefix argument is given, the message will be > -\"unarchived\", i.e. the tag changes in `notmuch-archive-tags' > -will be reversed." > +`notmuch-archive-tags' to it. If a prefix argument is given, the > +message will be \"unarchived\", i.e. the tag changes in > +`notmuch-archive-tags' will be reversed." > (interactive "P") > (when notmuch-archive-tags > (apply 'notmuch-show-tag-message > -- > 1.8.2.rc2 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch