Re: [PATCH] emacs: add buttons for all multipart/related parts

[Mark Walters <markwalters1009@gmail.com>]

On Fri, 16 Aug 2013, Istvan Marko <notmuch@kismala.com> wrote:
> When text/html parts include images as multipart/related and the
> text/plain alternative is used these images can be completely hidden
> with no easy way to access them or even find out that they are there.
>
> Make notmuch-show-insert-part-multipart/related add buttons for all
> parts, the first one visible the rest hidden.

Hello

This patch LGTM +1.

It is a clear improvement anyway but would benefit from my fix for the
bug this exposes
id:1377246875-7784-1-git-send-email-markwalters1009@gmail.com (or some
alternative). I don't know if we want to push the two together or just
push each as it gets reviewed.

Best wishes

Mark






> ---
>  emacs/notmuch-show.el | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 82b70ba..20844f0 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -621,6 +621,10 @@ message at DEPTH in the current thread."
>  
>      ;; Render the primary part.
>      (notmuch-show-insert-bodypart msg (car inner-parts) depth)
> +    ;; Add hidden buttons for the rest
> +    (mapc (lambda (inner-part)
> +	    (notmuch-show-insert-bodypart msg inner-part depth t))
> +	  (cdr inner-parts))
>  
>      (when notmuch-show-indent-multipart
>        (indent-rigidly start (point) 1)))
> -- 
> 1.8.1.4
>
>
>
>
> -- 
> 	Istvan
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch